-
-
Notifications
You must be signed in to change notification settings - Fork 56
Test percent encoded paths in static files #695
Copy link
Copy link
Open
Labels
next-roundWill not be implemented right now to keep the test results stable.Will not be implemented right now to keep the test results stable.testsAbout test design, issues with tests etc.About test design, issues with tests etc.
Description
Metadata
Metadata
Assignees
Labels
next-roundWill not be implemented right now to keep the test results stable.Will not be implemented right now to keep the test results stable.testsAbout test design, issues with tests etc.About test design, issues with tests etc.
According to the specc, frameworks must accept URIs as defined in RFC 3986, which means they have to accept percent encoded URLs. The typical use case for this are special characters in file names. Handling this adds an additional layer of complexity that is usually skipped when the server recognizes there is no
%in the URI.So to force the frameworks to decode the incoming URL, I would suggest to add a static file with a non-ASCII character in it's name which is requested by the client with percent encoding applied.
For example, we can add a file named
~@file name.txtwhich translates to%7E%40file%20name.txtand is a valid file name on both Linux and Windows.Include this file request in the validation as well as the benchmark itself to see whether there is a slow down in some frameworks.