From afad41e4e3754ce78b816bab3a856a13c0cf7ca2 Mon Sep 17 00:00:00 2001
From: MDA2AV <fabreis202@gmail.com>
Date: Fri, 24 Jul 2026 22:17:40 +0100
Subject: [PATCH] Fix duplicate env key that breaks benchmark-pr.yml
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

#1034 added `env: FRAMEWORK` to the "Commit saved results" step, which already
declared `env: GH_TOKEN` at its end. Two env keys in one step is invalid, and
GitHub rejects the entire file:

    failed to parse workflow: (Line: 160, Col: 9): 'env' is already defined

So /benchmark is currently dead on main — the workflow cannot be dispatched at
all. Merged into the existing block.

This slipped through because the check I ran was `yaml.safe_load`, and PyYAML
silently accepts duplicate mapping keys (last one wins) while GitHub Actions
does not. All six workflows now validate with a loader that raises on
duplicates instead.
---
 .github/workflows/benchmark-pr.yml | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/.github/workflows/benchmark-pr.yml b/.github/workflows/benchmark-pr.yml
index 189328b66..954e15551 100644
--- a/.github/workflows/benchmark-pr.yml
+++ b/.github/workflows/benchmark-pr.yml
@@ -134,8 +134,6 @@ jobs:
 
       - name: Commit saved results
         if: inputs.save == 'true'
-        env:
-          FRAMEWORK: ${{ inputs.framework }}
         run: |
           PR_DATA=$(gh api "/repos/${{ github.repository }}/pulls/${{ inputs.pr }}" --jq '.head.ref + " " + .head.repo.full_name')
           PR_BRANCH=$(echo "$PR_DATA" | awk '{print $1}')
@@ -159,6 +157,7 @@ jobs:
           fi
         env:
           GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+          FRAMEWORK: ${{ inputs.framework }}
 
       - name: Post results to PR
         if: always()