From 74517b02e2c166b5a45141a5eef90bc937e9e45b Mon Sep 17 00:00:00 2001
From: Sam Evans <s7evans11@gmail.com>
Date: Wed, 22 Jul 2026 14:10:59 -0400
Subject: [PATCH 1/3] clean up github PR form template

See #1595 for detailed description of PR form template issues
---
 .github/PULL_REQUEST_TEMPLATE.md | 32 +++++++++++++++++---------------
 1 file changed, 17 insertions(+), 15 deletions(-)

diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md
index 52e5160c3..81bd8a8eb 100644
--- a/.github/PULL_REQUEST_TEMPLATE.md
+++ b/.github/PULL_REQUEST_TEMPLATE.md
@@ -1,8 +1,10 @@
 <!--  The PR title should summarize the changes, for example "Add `Grid._build_face_dimension` function".
       Avoid non-descriptive titles such as "Addresses issue #229". -->
 
-<!--  Replace XXX with the number of the issue that this PR will resolve. If this PR closed more than one,
-      you may add a comma separated sequence-->
+<!--  Replace XXX with the issue number resolved by this PR, if this PR fully resolves an issue.
+      If it does not fully resolve any issues, replace with something like "Related to #XXX",
+          or "Fixes part of #YYY but does not fully close it."
+      If it resolves multiple issues, repeat "closes" for each, like "Closes #XXX, closes #YYY." -->
 Closes #XXX
 
 ## Overview
@@ -10,7 +12,7 @@ Closes #XXX
       points on any bug fixes, new functions, or other changes that have been made. -->
 
 ## Expected Usage
-<!--  If you are adding a feature into the Internal API, please produce a short example of it in action.
+<!--  If this PR adds a new feature, please provide a short example of it in action.
       You may ignore this step if it is not applicable (comment out this section). -->
 ```Python
 import uxarray as ux
@@ -25,7 +27,6 @@ some_output = uxds.some_function()
 
 # this is another way to use this function
 other_output = uxds.some_function(some_param = True)
-
 ```
 
 ## PR Checklist
@@ -33,8 +34,8 @@ other_output = uxds.some_function(some_param = True)
 apply to this PR, comment it out or delete it. -->
 
 **General**
-- [ ] An issue is linked created and linked
-- [ ] Add appropriate labels
+- [ ] An issue is created and linked
+- [ ] Added appropriate labels (if you have label edit permissions)
 - [ ] Filled out Overview and Expected Usage (if applicable) sections
 
 **Testing**
@@ -44,24 +45,25 @@ apply to this PR, comment it out or delete it. -->
 
 **Documentation**
 - [ ] Docstrings have been added to all new functions
-- [ ] Docstrings have updated with any function changes
-- [ ] Internal functions have a preceding underscore (`_`) and have been added to `docs/internal_api/index.rst`
-- [ ] User functions have been added to `docs/user_api/index.rst`
+- [ ] Docstrings have been updated with any function changes
+- [ ] User (public) functions have been added to `docs/api.rst`
+- [ ] Internal (private) function names start with an underscore (`_`)
+
 
 **Examples**
-- [ ] Any new notebook examples added to `docs/examples/` folder
-- [ ] Clear the output of all cells before committing
-- [ ] New notebook files added to `docs/examples.rst` toctree
-- [ ] New notebook files added to new entry in `docs/gallery.yml` with appropriate thumbnail photo in `docs/_static/thumbnails/`
+- [ ] New notebook examples cleared the output of all cells before committing
+- [ ] New notebook examples added to appropriate folder (gallery: `docs/examples/`; guide: `docs/user-guide/`; quickstart: `docs/getting-started/`)
+- [ ] New notebook examples referenced in appropriate .rst file (gallery: `docs/gallery.rst`; guide: `docs/userguide.rst`; quickstart: `docs/quickstart.rst`)
+- [ ] New notebook gallery examples added entry in `docs/gallery.yml` with appropriate thumbnail photo in `docs/_static/thumbnails/`
 
 <!--
 Thank you so much for your PR!  To help us review your contribution, please
 consider the following points:
 
 **PR Etiquette Reminders**
-- This PR should be listed as a draft PR until you are ready to request reviewers
+- This PR should be listed as a draft PR until you are ready for it to be reviewed
 
-- After making changes in accordance with the reviews, re-request your reviewers
+- After making changes in accordance with any reviews, re-request reviews from the same reviewers
 
 - Do *not* mark conversations as resolved if you didn't start them
 

From 6580446721b99d3655f38a27e14f4f0572c9c9f0 Mon Sep 17 00:00:00 2001
From: Sam Evans <47793072+Sevans711@users.noreply.github.com>
Date: Mon, 27 Jul 2026 14:57:40 -0400
Subject: [PATCH 2/3] minor improvements to github PR form

in response to reviewer comments on #1608
---
 .github/PULL_REQUEST_TEMPLATE.md | 11 ++++++-----
 1 file changed, 6 insertions(+), 5 deletions(-)

diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md
index 81bd8a8eb..3fb35a34c 100644
--- a/.github/PULL_REQUEST_TEMPLATE.md
+++ b/.github/PULL_REQUEST_TEMPLATE.md
@@ -30,28 +30,29 @@ other_output = uxds.some_function(some_param = True)
 ```
 
 ## PR Checklist
-<!-- Please mark any checkboxes that do not apply to this PR as [N/A]. If an entire section doesn't
-apply to this PR, comment it out or delete it. -->
+<!-- Please mark any checkboxes that do not apply to this PR as [N/A]. -->
 
 **General**
 - [ ] An issue is created and linked
-- [ ] Added appropriate labels (if you have label edit permissions)
+- [ ] Added appropriate labels (if your uxarray repo permissions allow it)
 - [ ] Filled out Overview and Expected Usage (if applicable) sections
 
 **Testing**
+<!--  If this PR does not update any functionality or tests, remove this section (Testing) -->
 - [ ] Adequate tests are created if there is new functionality
 - [ ] Tests cover all possible logical paths in your function
 - [ ] Tests are not too basic (such as simply calling a function and nothing else)
 
 **Documentation**
+<!--  If this PR does not update any functionality or docstrings, remove this section (Documentation) -->
 - [ ] Docstrings have been added to all new functions
 - [ ] Docstrings have been updated with any function changes
 - [ ] User (public) functions have been added to `docs/api.rst`
 - [ ] Internal (private) function names start with an underscore (`_`)
 
-
 **Examples**
-- [ ] New notebook examples cleared the output of all cells before committing
+<!--  If this PR does not update any examples, remove this section (Examples) -->
+- [ ] **All** notebook examples cleared the output of all cells before committing
 - [ ] New notebook examples added to appropriate folder (gallery: `docs/examples/`; guide: `docs/user-guide/`; quickstart: `docs/getting-started/`)
 - [ ] New notebook examples referenced in appropriate .rst file (gallery: `docs/gallery.rst`; guide: `docs/userguide.rst`; quickstart: `docs/quickstart.rst`)
 - [ ] New notebook gallery examples added entry in `docs/gallery.yml` with appropriate thumbnail photo in `docs/_static/thumbnails/`

From 9344c44e399d4b9fe2fe549aca94f81a5e8856ec Mon Sep 17 00:00:00 2001
From: Sam Evans <47793072+Sevans711@users.noreply.github.com>
Date: Tue, 28 Jul 2026 11:09:28 -0400
Subject: [PATCH 3/3] add benchmarking checklist item on PR form

---
 .github/PULL_REQUEST_TEMPLATE.md | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md
index 3fb35a34c..183bfaf90 100644
--- a/.github/PULL_REQUEST_TEMPLATE.md
+++ b/.github/PULL_REQUEST_TEMPLATE.md
@@ -37,11 +37,13 @@ other_output = uxds.some_function(some_param = True)
 - [ ] Added appropriate labels (if your uxarray repo permissions allow it)
 - [ ] Filled out Overview and Expected Usage (if applicable) sections
 
-**Testing**
-<!--  If this PR does not update any functionality or tests, remove this section (Testing) -->
+**Testing & Benchmarking**
+<!--  If this PR does not update any functionality or tests and is not intended to improve efficiency,
+    e.g. by reducing computation time or memory usage, remove this section (Testing & Benchmarking) -->
 - [ ] Adequate tests are created if there is new functionality
 - [ ] Tests cover all possible logical paths in your function
 - [ ] Tests are not too basic (such as simply calling a function and nothing else)
+- [ ] At least one ASV benchmark demonstrates improvements, if expected (add a new benchmark if necessary)
 
 **Documentation**
 <!--  If this PR does not update any functionality or docstrings, remove this section (Documentation) -->