Add option to configure --detach behavior in docker stack deploy

[kpwn243]

Currently, docker stack deploy defaults to --detach=true, but in future Docker releases, the default will change to false. This change could impact deployments using cssnr/stack-deploy-action.

I’d like to request an option in this action to explicitly control the --detach flag. This would allow users to:

• Ensure compatibility with both current and future Docker versions.
• Choose whether the action waits for the deployment to complete or returns immediately.

Proposed Solution:
Add an optional input to the action, default can be true (in line with current functionality) but can be toggled to true.

Use Case:
With --detach=false, users can see whether the deployment succeeds or fails directly in the action logs, improving visibility into stack updates.

Would this be feasible to add? Happy to provide more details if needed. Thanks for your work on this project!

[smashedr]

This is a solid request.

Options:
  -c, --compose-file strings
  -d, --detach              
      --prune               
  -q, --quiet               
      --resolve-image string
      --with-registry-auth  

Out of the stack deploy flags, I probably need to add options for detach, prune and possibly resolve-image.

I will try to get these added ASAP.

[smashedr]

I have this feature working in this PR: #22

You can view the output and summary by clicking on a recent Test workflow run:
https://github.com/cssnr/stack-deploy-action/actions/workflows/test.yaml?query=branch%3Adeploy

This can be tested by using the branch: uses: cssnr/stack-deploy-action@deploy

Testing is optional, I have already tested the arguments and added them to the 2 included test.yaml workflow.

The README.md for the branch is available here: https://github.com/cssnr/stack-deploy-action/tree/deploy?tab=readme-ov-file#readme

Unless you have any feedback, I will get this released a little later today.

[smashedr]

The only caveat here is docker is flushing the output of --detach=false every loop as it checks and updates the output. In the console that looks normal, but on the action logs it creates a new log line on every output.

This is not an at all an issue, and the output is still all there and readable for debugging, just a bit long and repetitive.

• If you set detach to anything but true it will add --detach=false
• If you set prune to anything but false it will add --prune
• If you set resolve_image to changed or never it will add --resolve-image=changed|never

Setting resolve_image to anything other than always, changed, never creates an Error annotation and uses default (omits the argument).

I think I am now happy with the changes. I will merge and release this here shortly...

[smashedr]

I have released this change in v1.2.0. You can use the new version with any of these tags:

cssnr/stack-deploy-action@v1
cssnr/stack-deploy-action@v1.2
cssnr/stack-deploy-action@v1.2.0

Let me know if you have any issues. Thank you for the feedback.

[smashedr]

I just released a new version v1.3.0. Inspired by this thread, I looked into the deploy command, and it now does the following:

• Capture the output and error while echoing it to the logs
• Capture the exit status of the deploy command
• Add the error output to the Job Summary
• Report Failed if the stack deploy command fails

exec 5>&1
STACK_RESULTS=$( "${COMMAND[@]}" 2>&1 | tee >(cat >&5) ; exit "${PIPESTATUS[0]}" )
EXIT_STATUS="$?"

I bumped the minor version because I also added compose support. You can use the latest version with one of these tags:

cssnr/stack-deploy-action@v1
cssnr/stack-deploy-action@v1.3
cssnr/stack-deploy-action@v1.3.0

Thanks again for the support...

[kpwn243]

Wow, thanks for going above and beyond on this feature request. This is awesome