Create Hibernate implementation of ApplicationErrorDao in dropwizard-application-errors?

[sleberknight]

This would allow us to use that implementation in the services that are using Hibernate, instead of having to create a JDBI-based instance.

Considerations and possible pitfalls and road blocks:

Annotations
This could this be problematic since ApplicationError doesn't have all the JPA/Hibernate persistence annotations (and I don't want to put all those all over it)

Internal Model
Would probably need some kind of "internal" model (e.g. HibernateApplicationError) that is used by Hibernate and then we would have to transform it into regular ApplicationError objects. That would be annoying, but would probably work.

Sessions and Exceptions
This could cause other problems, aside from the issues mentioned above. Most significantly, if a Hibernate exception is thrown by persistence code, and then the Hibernate-based ApplicationErrorDao uses the same Session, then it will also fail since the Session is "unsafe" at that point. We'd have to guarantee it always uses a new Session. This could be accomplished by supplying a SessionFactory to the DAO's constructor, and always using a new Session when saving application errors.

As long as we guarantee a separate Session it should work. We should consider using a StatelessSession since there is no need to cache the saved ApplicationError.

[sleberknight]

Because of the various pitfalls described above, we decided not to even try to do this. It will probably be complicated, and will not provide much benefit. Instead #248 (plain JDBC implementation of ApplicationErrorDao) can be used in services that use Hibernate, and without requiring any additional dependencies.