feat(pr-review): collapse answered open questions - #96
Merged
Troublor merged 1 commit intoJul 28, 2026
Conversation
Publish each open question inside a <details> block that starts expanded, and collapse it when a later round marks it answered or withdrawn. Once a question is closed its why-it-matters and how-to-verify bullets are only history, so it reads as a single green summary line that still expands to the original question rather than losing it. The in-place rewrite now swaps the two-line details/summary header instead of a single line. It still reproduces the marker, so re-applying stays a no-op, and a question published before this shape existed falls back to the old single-line rewrite.
Claude review status
✅ Review clean Last reviewed: head New this round: 0 finding(s), 0 question(s) · Resolved this round: 0 · Open questions: 0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Answered questions kept their full rationale expanded forever. Once a question is closed, the why it matters and how to verify bullets are only history — but deleting them loses the record of what was asked, which is exactly what someone reading the thread later wants.
So: collapse, do not discard.
<details open>block.answeredorwithdrawn, the in-place rewrite swaps the two-line<details>/<summary>header, dropping theopenattribute. The question reads as one✅ **Answered** — <reason>line that expands to the original question, why it mattered, and how to verify it.<details>into a body with no closing tag.Follow-up to #94.
Test plan
python3 -m unittest discover -s .github/actions/claude-pr-review -p 'test_*.py'— 70 pass, 4 new: open questions render expanded, answering collapses the block while keeping the bullets, the collapse rewrite is idempotent, and a legacy single-line question still annotates.mise run lint— clean.