From 698a02e357de0fcc45db65f2aa312d9fd70ad95a Mon Sep 17 00:00:00 2001 From: henz Date: Mon, 27 Jul 2026 22:19:17 +0800 Subject: [PATCH] Add missing @sourceacademy/conductor devDependency to modules-buildtools modules-buildtools/src/build/docs/__tests__/conductor.test.ts processes the real source of the repeat and rune bundles through TypeDoc to test doc normalization. Both bundles import types from @sourceacademy/conductor, but buildtools never declared it as a dependency of its own. This was invisible in a full workspace install (hoisting made it resolvable anyway) but breaks in the isolated `yarn workspaces focus` install CI uses for the modules-buildtools library job, where TypeDoc can't resolve the imported types and falls back to a bare 'default' export instead of discovering the repeat/twice/thrice and rune method members. @sourceacademy/modules-lib was also a candidate (rune also imports from it), but adding it creates a circular dependency since modules-lib already depends on modules-buildtools. @sourceacademy/conductor alone is enough to fix both failing tests. --- lib/buildtools/package.json | 1 + yarn.lock | 1 + 2 files changed, 2 insertions(+) diff --git a/lib/buildtools/package.json b/lib/buildtools/package.json index 847b5ae42a..253c054d1f 100644 --- a/lib/buildtools/package.json +++ b/lib/buildtools/package.json @@ -5,6 +5,7 @@ "version": "1.1.0", "devDependencies": { "@commander-js/extra-typings": "^15.0.0", + "@sourceacademy/conductor": "catalog:", "@types/estree": "^1.0.0", "@types/http-server": "^0.12.4", "@types/node": "^24.0.0", diff --git a/yarn.lock b/yarn.lock index a0798c2520..5b6ff415ca 100644 --- a/yarn.lock +++ b/yarn.lock @@ -4513,6 +4513,7 @@ __metadata: resolution: "@sourceacademy/modules-buildtools@workspace:lib/buildtools" dependencies: "@commander-js/extra-typings": "npm:^15.0.0" + "@sourceacademy/conductor": "catalog:" "@sourceacademy/modules-repotools": "workspace:^" "@sourceacademy/modules-typedoc-plugin": "workspace:^" "@types/estree": "npm:^1.0.0"