Support fully-private GKE clusters and configurable proxy pod readiness timeout#283
Open
likewei92 wants to merge 2 commits into
Open
Support fully-private GKE clusters and configurable proxy pod readiness timeout#283likewei92 wants to merge 2 commits into
likewei92 wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two improvements to the Shared Pathways Service ISC (Interactive Single Controller)
connection flow to better support real-world GKE cluster configurations.
Changes
1. Make
--dns-endpointoptional for fully-private clustersfetch_cluster_credentialspreviously always passed--dns-endpointtogcloud container clusters get-credentials. This breaks on fully-privateclusters whose DNS and public endpoints are both disabled.
use_dns_endpointparameter (defaultTrue) tofetch_cluster_credentials, threaded throughisc_pathways.connect().--use_dns_endpointflag tostart_vscode_on_cpu_np.py.False, credentials are fetched via the reachable private IPendpoint instead.
2. Make proxy pod readiness timeout configurable
The proxy pod wait used kubectl's short default timeout, which could expire while
a node cold-starts from zero (cluster autoscaling + image pull).
DEFAULT_POD_READY_TIMEOUT_S(60s) ingke_utils.wait_for_podnow accepts atimeoutparameter.proxy_pod_ready_timeout_sonisc_pathways.connect()so callers canincrease the wait for pools that autoscale from zero.
Files Changed
gke_utils.py— new timeout constant,use_dns_endpointandtimeoutparamsisc_pathways.py— plumb both new options throughconnect()start_vscode_on_cpu_np.py— new--use_dns_endpointflag