[PWGHF] Implement checks for correlated backgrounds and for B->J/Psi(->ee)X decays in B->J/Psi workflow by fchinu · Pull Request #17034 · AliceO2Group/O2Physics

fchinu · 2026-07-13T07:20:38Z

No description provided.

…ecays in B->J/Psi workflow

github-actions · 2026-07-13T07:20:56Z

O2 linter results: ❌ 0 errors, ⚠️ 1 warnings, 🔕 0 disabled

alibuild · 2026-07-13T08:00:42Z

Error while checking build/O2Physics/o2 for f8f1a3d at 2026-07-13 10:00:

## sw/BUILD/O2Physics-latest/log
c++: fatal error: Killed signal terminated program cc1plus
c++: fatal error: Killed signal terminated program cc1plus
ninja: build stopped: subcommand failed.

Full log here.

alibuild · 2026-07-13T09:31:33Z

Error while checking build/O2Physics/staging for f8f1a3d at 2026-07-13 11:31:

## sw/BUILD/O2Physics-latest/log
c++: fatal error: Killed signal terminated program cc1plus
c++: fatal error: Killed signal terminated program cc1plus
ninja: build stopped: subcommand failed.

Full log here.

alibuild · 2026-07-13T09:34:03Z

Error while checking build/O2Physics/code-check for efde8ae at 2026-07-15 01:44:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 8 errors and 0 warnings.'
Found 8 errors and 0 warnings.
++ [[ 8 -gt 0 ]]
++ cat /sw/BUILD/775885ab34eb5b40fb702901366d0216653edf65/O2Physics-code-check/errors.txt
PWGHF/D2H/TableProducer/dataCreatorJpsiHadReduced.cxx:105:65: error: variable 'partlyRecoDecayMapMuMu' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGHF/D2H/TableProducer/dataCreatorJpsiHadReduced.cxx:110:65: error: variable 'partlyRecoDecayMapEE' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGHF/D2H/Tasks/taskB0ToJpsiK0StarReduced.cxx:241:52: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
PWGHF/D2H/Tasks/taskB0ToJpsiK0StarReduced.cxx:259:60: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
PWGHF/D2H/Tasks/taskBplusToJpsiKReduced.cxx:214:52: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
PWGHF/D2H/Tasks/taskBplusToJpsiKReduced.cxx:231:60: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
PWGHF/D2H/Tasks/taskBsToJpsiPhiReduced.cxx:239:52: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
PWGHF/D2H/Tasks/taskBsToJpsiPhiReduced.cxx:256:60: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
++ [[ 0 -gt 0 ]]
++ [[ 8 -gt 0 ]]
++ exit 1
--

Full log here.

fgrosa

Thanks @fchinu! A couple of comments below

fgrosa · 2026-07-13T12:57:54Z

+    if (std::accumulate(doProcess.begin(), doProcess.end(), 0) == 0) {
+      LOGP(fatal, "Enable at least one process function, please fix your configuration!");


Is more than one process function enabled allowed?

Yes, I have removed the restriction. Now you can enable more than one process function (though never both data and MC for the same particle)

fgrosa · 2026-07-13T13:00:48Z

+        // Partly reconstructed decays, i.e. the 3 prongs have a common b-hadron ancestor
+        // convention: final state particles are prong0,1,2
+        if (!flag) {
+          auto particleProng0 = vecDaughtersB[0].mcParticle();
+          auto particleProng1 = vecDaughtersB[1].mcParticle();
+          auto particleProng2 = vecDaughtersB[2].mcParticle();
+          // b-hadron hypothesis
+          std::array<int, 3> const bHadronMotherHypos = {Pdg::kB0, Pdg::kBS, Pdg::kLambdaB0};
+
+          for (const auto& bHadronMotherHypo : bHadronMotherHypos) {
+            int const index0Mother = RecoDecay::getMother(particlesMc, particleProng0, bHadronMotherHypo, true);
+            int const index1Mother = RecoDecay::getMother(particlesMc, particleProng1, bHadronMotherHypo, true);
+            int const index2Mother = RecoDecay::getMother(particlesMc, particleProng2, bHadronMotherHypo, true);
+
+            // look for common b-hadron ancestor
+            if (index0Mother > -1 && index1Mother > -1 && index2Mother > -1) {
+              if (index0Mother == index1Mother && index1Mother == index2Mother) {
+                int pdgCodeBeautyMother = particlesMc.rawIteratorAt(index0Mother).pdgCode();
+                // look for common J/psi-hadron mother among prongs 0, 1 and 2
+                int const index0JpsiMother = RecoDecay::getMother(particlesMc, particleProng0, Pdg::kJPsi, true, &sign, 1);
+                int const index1JpsiMother = RecoDecay::getMother(particlesMc, particleProng1, Pdg::kJPsi, true, &sign, 1);
+                if (index0JpsiMother > -1 && index1JpsiMother > -1 && index0JpsiMother == index1JpsiMother) {
+                  if (std::abs(particleProng0.pdgCode()) == kMuonMinus && std::abs(particleProng1.pdgCode()) == kMuonMinus) {
+                    flag = partlyRecoDecayMapMuMu[std::abs(pdgCodeBeautyMother)];
+                  } else if (std::abs(particleProng0.pdgCode()) == kElectron && std::abs(particleProng1.pdgCode()) == kElectron) {
+                    flag = partlyRecoDecayMapEE[std::abs(pdgCodeBeautyMother)];
+                  }
+                  break;
+                }
+              }
+            }
+          }


In principle this could be done more easily with the function

O2Physics/Common/Core/RecoDecay.h

Lines 733 to 734 in 13b7152

template <bool acceptFlavourOscillation = false, bool checkProcess = false, bool acceptIncompleteReco = false, bool acceptTrackDecay = false, bool acceptTrackIntWithMaterial = false, std::size_t N, typename T, typename U>

static int getMatchedMCRec(const T& particlesMC,

enabling the acceptIncompleteReco flag, or am I missing something?
It can also be modified in a subsequent PR in case

Indeed, thanks! One needs to require that the other particle stems from the same mother as of the J/Psi. I have implemented it

fgrosa · 2026-07-13T13:02:41Z

+      if (checkDecayTypeMc) {
+        // B+ → J/Psi K+ → (e+e-) K+
+        if (!flag) {
+          indexRec = RecoDecay::getMatchedMCRec<true, false, false, true, true>(particlesMc, std::array{vecDaughtersB[0], vecDaughtersB[1], vecDaughtersB[2]}, Pdg::kBPlus, std::array{-kElectron, +kElectron, +kKPlus}, true, &sign, 3);


This is the only important comment: we have to accept incomplete decays, because we often have a photon emitted which ends up in the decay chain (in particular for the EE channel, but also with MuMu if I am not mistaken)

alibuild · 2026-07-13T23:24:49Z

Error while checking build/O2Physics/staging for efde8ae at 2026-07-14 01:24:

## sw/BUILD/O2Physics-latest/log
c++: fatal error: Killed signal terminated program cc1plus
c++: fatal error: Killed signal terminated program cc1plus
c++: fatal error: Killed signal terminated program cc1plus
ninja: build stopped: subcommand failed.

Full log here.

fchinu · 2026-07-15T07:28:34Z

Hi @fgrosa, thanks a lot for your review! I have implemented your comments, please let me know if you spot any other issues in the new code :)

alibuild · 2026-07-15T08:46:18Z

Error while checking build/O2Physics/o2 for 89c52c6 at 2026-07-15 10:46:

## sw/BUILD/O2Physics-latest/log
c++: fatal error: Killed signal terminated program cc1plus
c++: fatal error: Killed signal terminated program cc1plus
ninja: build stopped: subcommand failed.

Full log here.

Implement checks for correlated backgrounds and for B->J/Psi(->ee)X d…

f8f1a3d

…ecays in B->J/Psi workflow

fchinu requested review from NicoleBastid, alibuild, apalasciano, deepathoms, fcatalan92, fcolamar, fgrosa, gluparel, hahassan7, jpxrk, mfaggin, mmazzilli, singhra1994, stefanopolitano, vkucera and zhangbiao-phy as code owners July 13, 2026 07:20

github-actions Bot added the pwghf PWG-HF label Jul 13, 2026

github-actions Bot changed the title ~~Implement checks for correlated backgrounds and for B->J/Psi(->ee)X decays in B->J/Psi workflow~~ [PWGHF] Implement checks for correlated backgrounds and for B->J/Psi(->ee)X decays in B->J/Psi workflow Jul 13, 2026

Linting

efde8ae

fgrosa requested changes Jul 13, 2026

View reviewed changes

Consider also bremsstrahlung

89c52c6

fchinu requested a review from xinyepeng as a code owner July 15, 2026 07:24

		if (std::accumulate(doProcess.begin(), doProcess.end(), 0) == 0) {
		LOGP(fatal, "Enable at least one process function, please fix your configuration!");

	template <bool acceptFlavourOscillation = false, bool checkProcess = false, bool acceptIncompleteReco = false, bool acceptTrackDecay = false, bool acceptTrackIntWithMaterial = false, std::size_t N, typename T, typename U>
	static int getMatchedMCRec(const T& particlesMC,

Uh oh!

Conversation

fchinu commented Jul 13, 2026

Uh oh!

github-actions Bot commented Jul 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

alibuild commented Jul 13, 2026

Uh oh!

alibuild commented Jul 13, 2026

Uh oh!

alibuild commented Jul 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

fgrosa left a comment

Choose a reason for hiding this comment

Uh oh!

fgrosa Jul 13, 2026

Choose a reason for hiding this comment

Uh oh!

fchinu Jul 15, 2026

Choose a reason for hiding this comment

Uh oh!

fgrosa Jul 13, 2026

Choose a reason for hiding this comment

Uh oh!

fchinu Jul 15, 2026

Choose a reason for hiding this comment

Uh oh!

fgrosa Jul 13, 2026

Choose a reason for hiding this comment

Uh oh!

alibuild commented Jul 13, 2026

Uh oh!

fchinu commented Jul 15, 2026

Uh oh!

alibuild commented Jul 15, 2026

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

3 participants

github-actions Bot commented Jul 13, 2026 •

edited

Loading

alibuild commented Jul 13, 2026 •

edited

Loading