Skip to content

[Common,PWGLF] Add event preselections in strangeness derived data producer#17066

Open
romainschotter wants to merge 11 commits into
AliceO2Group:masterfrom
romainschotter:test
Open

[Common,PWGLF] Add event preselections in strangeness derived data producer#17066
romainschotter wants to merge 11 commits into
AliceO2Group:masterfrom
romainschotter:test

Conversation

@romainschotter

Copy link
Copy Markdown
Collaborator
  • add event preselections in strangeness derived data producer, in order to save only the collision tables from the collisions of interest,
  • add event preselections in strangeness builder, in order to save only the V0 and cascade tables from the collisions of interest,
  • Inherit preselections from the strangenessBuilderModule to prevent possible discrepancies between the event selections in the strangeness derived data producer and strangeness builder,
  • add table StraSelections to keep track of the total number of collisions and number of preselected collisions
  • adapt strangeness TOF PID task and data model to be functional with preselections
  • adapt derivedlambdakzeroanalysis in order to test the PR

Changes tested in pp, Pb-Pb (and MC) over the files:

  • for pp: /alice/data/2026/LHC26ac/570243/apass1/2340/o2_ctf_run00570243_orbit0271376640_tf0007836541_epn212/003/AO2D.root
  • for Pb-Pb: /alice/data/2025/LHC25an/568227/apass1/2250/o2_ctf_run00568227_orbit0049280448_tf0000745344_epn200/003/AO2D.root
  • for MC: /alice/sim/2026/LHC26e9/0/570143/2442/AO2D.root

Requiring NoITSROFBorder, NoTFBorder, NoSameBunchPileUp,|PVz|< 10 cm, and CBT hadron PID:

  • reduction factor 38 --> 68 in pp.
  • reduction factor 82 --> 97 in Pb-Pb.

@github-actions github-actions Bot changed the title Add event preselections in strangeness derived data producer [Common,PWGLF] Add event preselections in strangeness derived data producer Jul 14, 2026
@github-actions

Copy link
Copy Markdown

O2 linter results: ❌ 310 errors, ⚠️ 152 warnings, 🔕 0 disabled

@alibuild

alibuild commented Jul 15, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for ed5da69 at 2026-07-15 10:30:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 187 errors and 184 warnings.'
Found 187 errors and 184 warnings.
++ [[ 187 -gt 0 ]]
++ cat /sw/BUILD/99568067a6bf4f7aa5b14e228c68f1e84a1cec19/O2Physics-code-check/errors.txt
Common/TableProducer/propagationServiceRun2.cxx:63:8: error: constructor does not initialize these fields: ccdb [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
Common/TableProducer/propagationServiceV2.cxx:68:8: error: constructor does not initialize these fields: ccdb [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
Common/TableProducer/propagationService.cxx:65:8: error: constructor does not initialize these fields: ccdb [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
PWGLF/DataModel/LFStrangenessPIDTables.h:37:1: error: nested namespaces can be concatenated [modernize-concat-nested-namespaces,-warnings-as-errors]
PWGLF/DataModel/LFStrangenessPIDTables.h:61:32: error: casting (double + 0.5) to integer leads to incorrect rounding; consider using lround (#include <cmath>) instead [bugprone-incorrect-roundings,-warnings-as-errors]
PWGLF/DataModel/LFStrangenessTables.h:60:72: error: redundant boolean literal in ternary expression result [readability-simplify-boolean-expr,-warnings-as-errors]
PWGLF/DataModel/LFStrangenessTables.h:672:52: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGLF/DataModel/LFStrangenessTables.h:673:52: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGLF/DataModel/LFStrangenessTables.h:674:48: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGLF/DataModel/LFStrangenessTables.h:675:48: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGLF/DataModel/LFStrangenessTables.h:676:52: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGLF/DataModel/LFStrangenessTables.h:677:52: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGLF/DataModel/LFStrangenessTables.h:1315:37: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGLF/DataModel/LFStrangenessTables.h:1319:37: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGLF/DataModel/LFStrangenessTables.h:1322:50: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGLF/DataModel/LFStrangenessTables.h:1323:54: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGLF/DataModel/LFStrangenessTables.h:1324:66: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGLF/DataModel/LFStrangenessTables.h:1325:66: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGLF/DataModel/LFStrangenessTables.h:1328:36: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGLF/TableProducer/Strangeness/Converters/stradautrackstofpidconverter4.cxx:30:3: error: no header providing "o2::framework::Produces" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGLF/TableProducer/Strangeness/Converters/stradautrackstofpidconverter4.cxx:37:7: error: no header providing "uint64_t" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGLF/TableProducer/Strangeness/strangederivedbuilder.cxx:81:9: error: function-like macro 'bitset' used; consider a 'constexpr' template function [cppcoreguidelines-macro-usage,-warnings-as-errors]
PWGLF/TableProducer/Strangeness/strangederivedbuilder.cxx:82:9: error: function-like macro 'bitcheck' used; consider a 'constexpr' template function [cppcoreguidelines-macro-usage,-warnings-as-errors]
PWGLF/TableProducer/Strangeness/strangederivedbuilder.cxx:84:8: error: constructor does not initialize these fields: pdg [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
PWGLF/TableProducer/Strangeness/strangederivedbuilder.cxx:172:16: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGLF/TableProducer/Strangeness/strangederivedbuilder.cxx:173:20: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGLF/TableProducer/Strangeness/strangederivedbuilder.cxx:181:56: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
PWGLF/TableProducer/Strangeness/strangederivedbuilder.cxx:205:15: error: redundant string initialization [readability-redundant-string-init,-warnings-as-errors]
PWGLF/TableProducer/Strangeness/strangederivedbuilder.cxx:290:39: error: the parameter 'collision' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param,-warnings-as-errors]
PWGLF/TableProducer/Strangeness/strangederivedbuilder.cxx:323:9: error: implicit conversion 'bool' -> 'int' [readability-implicit-bool-conversion,-warnings-as-errors]
PWGLF/TableProducer/Strangeness/strangederivedbuilder.cxx:324:11: error: implicit conversion 'bool' -> 'int' [readability-implicit-bool-conversion,-warnings-as-errors]
PWGLF/TableProducer/Strangeness/strangederivedbuilder.cxx:325:11: error: implicit conversion 'bool' -> 'int' [readability-implicit-bool-conversion,-warnings-as-errors]
PWGLF/TableProducer/Strangeness/strangederivedbuilder.cxx:326:11: error: implicit conversion 'bool' -> 'int' [readability-implicit-bool-conversion,-warnings-as-errors]
PWGLF/TableProducer/Strangeness/strangederivedbuilder.cxx:327:11: error: implicit conversion 'bool' -> 'int' [readability-implicit-bool-conversion,-warnings-as-errors]
PWGLF/TableProducer/Strangeness/strangederivedbuilder.cxx:328:11: error: implicit conversion 'bool' -> 'int' [readability-implicit-bool-conversion,-warnings-as-errors]
PWGLF/TableProducer/Strangeness/strangederivedbuilder.cxx:332:9: error: implicit conversion 'bool' -> 'int' [readability-implicit-bool-conversion,-warnings-as-errors]
PWGLF/TableProducer/Strangeness/strangederivedbuilder.cxx:333:11: error: implicit conversion 'bool' -> 'int' [readability-implicit-bool-conversion,-warnings-as-errors]
PWGLF/TableProducer/Strangeness/strangederivedbuilder.cxx:334:11: error: implicit conversion 'bool' -> 'int' [readability-implicit-bool-conversion,-warnings-as-errors]
PWGLF/TableProducer/Strangeness/strangederivedbuilder.cxx:335:11: error: implicit conversion 'bool' -> 'int' [readability-implicit-bool-conversion,-warnings-as-errors]
PWGLF/TableProducer/Strangeness/strangederivedbuilder.cxx:336:11: error: implicit conversion 'bool' -> 'int' [readability-implicit-bool-conversion,-warnings-as-errors]
PWGLF/TableProducer/Strangeness/strangederivedbuilder.cxx:1381:7: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGLF/TableProducer/Strangeness/strangenesstofpid.cxx:91:8: error: constructor does not initialize these fields: ccdb, mTOFResponse, nSigmaCalibLoaded, mRunNumber, d_bz, maxSnp, maxStep [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
[0 more errors; see full log]

Full log here.

@alibuild

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/staging for ed5da69 at 2026-07-15 09:28:

## sw/BUILD/O2Physics-latest/log
c++: fatal error: Killed signal terminated program cc1plus
ninja: build stopped: subcommand failed.

Full log here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

2 participants