[PWGDQ] remove unused code by ypwangg · Pull Request #17068 · AliceO2Group/O2Physics

ypwangg · 2026-07-15T01:44:24Z

Remove unused code for coherent Jpsi A2 and update the variables
Add v2 definition in Psi2C (to test event plane performance using hadronic v2)
Fix some bugs in event mixing for A2. And added some variables

github-actions · 2026-07-15T01:44:43Z

O2 linter results: ❌ 111 errors, ⚠️ 797 warnings, 🔕 0 disabled

alibuild · 2026-07-15T01:58:50Z

Error while checking build/O2Physics/code-check for 7d77a63 at 2026-07-15 03:58:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 196 errors and 1 warnings.'
Found 196 errors and 1 warnings.
++ [[ 196 -gt 0 ]]
++ cat /sw/BUILD/209f62f43f63b9e8cdc3ec202dfc283705e17844/O2Physics-code-check/errors.txt
PWGDQ/Core/HistogramsLibrary.cxx:302:128: error: use nullptr [modernize-use-nullptr,-warnings-as-errors]
PWGDQ/Core/HistogramsLibrary.cxx:303:128: error: use nullptr [modernize-use-nullptr,-warnings-as-errors]
PWGDQ/Core/HistogramsLibrary.cxx:747:9: error: uninitialized record type: 'pIN_bins' [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
PWGDQ/Core/HistogramsLibrary.cxx:756:9: error: uninitialized record type: 'TPCdEdx_bins' [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
PWGDQ/Core/HistogramsLibrary.cxx:762:9: error: uninitialized record type: 'nSigma_bins' [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
PWGDQ/Core/HistogramsLibrary.cxx:825:7: error: uninitialized record type: 'tpcNsigmaBinLims' [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
PWGDQ/Core/HistogramsLibrary.cxx:837:7: error: uninitialized record type: 'tpcNclusterBinLims' [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
PWGDQ/Core/HistogramsLibrary.cxx:885:9: error: uninitialized record type: 'pIN_bins' [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
PWGDQ/Core/HistogramsLibrary.cxx:894:9: error: uninitialized record type: 'TOFbeta_bins' [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
PWGDQ/Core/HistogramsLibrary.cxx:900:9: error: uninitialized record type: 'nSigma_bins' [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
PWGDQ/Core/HistogramsLibrary.cxx:922:7: error: uninitialized record type: 'pIN_bins' [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
PWGDQ/Core/HistogramsLibrary.cxx:934:7: error: uninitialized record type: 'pIN_binsmore' [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
PWGDQ/Core/HistogramsLibrary.cxx:948:7: error: uninitialized record type: 'nSigma_bins' [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
PWGDQ/Core/HistogramsLibrary.cxx:954:7: error: uninitialized record type: 'nSigma_binsmore' [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
PWGDQ/Core/HistogramsLibrary.cxx:960:7: error: uninitialized record type: 'nSigma_binsgrob' [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
PWGDQ/Core/HistogramsLibrary.cxx:966:7: error: uninitialized record type: 'TOFbeta_bins' [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
PWGDQ/Core/HistogramsLibrary.cxx:972:7: error: uninitialized record type: 'TPCdEdx_bins' [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
PWGDQ/Core/HistogramsLibrary.cxx:1151:7: error: uninitialized record type: 'PtBinEdges' [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
PWGDQ/Core/HistogramsLibrary.cxx:1160:7: error: uninitialized record type: 'CentBinEdges' [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
PWGDQ/Core/HistogramsLibrary.cxx:1207:134: error: use nullptr [modernize-use-nullptr,-warnings-as-errors]
PWGDQ/Core/HistogramsLibrary.cxx:1208:134: error: use nullptr [modernize-use-nullptr,-warnings-as-errors]
PWGDQ/Core/HistogramsLibrary.cxx:1254:5: error: uninitialized record type: 'coschiBins' [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
PWGDQ/Core/HistogramsLibrary.cxx:1268:124: error: use nullptr [modernize-use-nullptr,-warnings-as-errors]
PWGDQ/Core/HistogramsLibrary.cxx:1269:124: error: use nullptr [modernize-use-nullptr,-warnings-as-errors]
PWGDQ/Core/HistogramsLibrary.cxx:1270:124: error: use nullptr [modernize-use-nullptr,-warnings-as-errors]
PWGDQ/Core/HistogramsLibrary.cxx:1319:7: error: uninitialized record type: 'massBins' [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
PWGDQ/Core/HistogramsLibrary.cxx:1323:7: error: uninitialized record type: 'ptBins' [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
PWGDQ/Core/HistogramsLibrary.cxx:1354:9: error: uninitialized record type: 'massBins' [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
PWGDQ/Core/HistogramsLibrary.cxx:1365:146: error: use nullptr [modernize-use-nullptr,-warnings-as-errors]
PWGDQ/Core/HistogramsLibrary.cxx:1373:146: error: use nullptr [modernize-use-nullptr,-warnings-as-errors]
PWGDQ/Core/HistogramsLibrary.cxx:1419:9: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGDQ/Core/HistogramsLibrary.cxx:1423:146: error: use nullptr [modernize-use-nullptr,-warnings-as-errors]
PWGDQ/Core/HistogramsLibrary.cxx:1424:176: error: use nullptr [modernize-use-nullptr,-warnings-as-errors]
PWGDQ/Core/HistogramsLibrary.cxx:1429:147: error: use nullptr [modernize-use-nullptr,-warnings-as-errors]
PWGDQ/Core/HistogramsLibrary.cxx:1430:177: error: use nullptr [modernize-use-nullptr,-warnings-as-errors]
PWGDQ/Core/HistogramsLibrary.cxx:1435:147: error: use nullptr [modernize-use-nullptr,-warnings-as-errors]
PWGDQ/Core/HistogramsLibrary.cxx:1436:177: error: use nullptr [modernize-use-nullptr,-warnings-as-errors]
PWGDQ/Core/HistogramsLibrary.cxx:1475:134: error: use nullptr [modernize-use-nullptr,-warnings-as-errors]
PWGDQ/Core/HistogramsLibrary.cxx:1484:138: error: use nullptr [modernize-use-nullptr,-warnings-as-errors]
PWGDQ/Core/HistogramsLibrary.cxx:1493:134: error: use nullptr [modernize-use-nullptr,-warnings-as-errors]
PWGDQ/Core/HistogramsLibrary.cxx:1554:9: error: uninitialized record type: 'TauBinLims' [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
PWGDQ/Core/HistogramsLibrary.cxx:1588:132: error: use nullptr [modernize-use-nullptr,-warnings-as-errors]
[0 more errors; see full log]

Full log here.

alibuild · 2026-07-15T03:16:12Z

Error while checking build/O2Physics/code-check for d39e480 at 2026-07-15 05:16:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 196 errors and 1 warnings.'
Found 196 errors and 1 warnings.
++ [[ 196 -gt 0 ]]
++ cat /sw/BUILD/5dd207a45dcd88b59a2f4b57a14beeead963d77c/O2Physics-code-check/errors.txt
PWGDQ/Core/HistogramsLibrary.cxx:302:128: error: use nullptr [modernize-use-nullptr,-warnings-as-errors]
PWGDQ/Core/HistogramsLibrary.cxx:303:128: error: use nullptr [modernize-use-nullptr,-warnings-as-errors]
PWGDQ/Core/HistogramsLibrary.cxx:747:9: error: uninitialized record type: 'pIN_bins' [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
PWGDQ/Core/HistogramsLibrary.cxx:756:9: error: uninitialized record type: 'TPCdEdx_bins' [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
PWGDQ/Core/HistogramsLibrary.cxx:762:9: error: uninitialized record type: 'nSigma_bins' [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
PWGDQ/Core/HistogramsLibrary.cxx:825:7: error: uninitialized record type: 'tpcNsigmaBinLims' [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
PWGDQ/Core/HistogramsLibrary.cxx:837:7: error: uninitialized record type: 'tpcNclusterBinLims' [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
PWGDQ/Core/HistogramsLibrary.cxx:885:9: error: uninitialized record type: 'pIN_bins' [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
PWGDQ/Core/HistogramsLibrary.cxx:894:9: error: uninitialized record type: 'TOFbeta_bins' [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
PWGDQ/Core/HistogramsLibrary.cxx:900:9: error: uninitialized record type: 'nSigma_bins' [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
PWGDQ/Core/HistogramsLibrary.cxx:922:7: error: uninitialized record type: 'pIN_bins' [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
PWGDQ/Core/HistogramsLibrary.cxx:934:7: error: uninitialized record type: 'pIN_binsmore' [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
PWGDQ/Core/HistogramsLibrary.cxx:948:7: error: uninitialized record type: 'nSigma_bins' [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
PWGDQ/Core/HistogramsLibrary.cxx:954:7: error: uninitialized record type: 'nSigma_binsmore' [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
PWGDQ/Core/HistogramsLibrary.cxx:960:7: error: uninitialized record type: 'nSigma_binsgrob' [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
PWGDQ/Core/HistogramsLibrary.cxx:966:7: error: uninitialized record type: 'TOFbeta_bins' [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
PWGDQ/Core/HistogramsLibrary.cxx:972:7: error: uninitialized record type: 'TPCdEdx_bins' [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
PWGDQ/Core/HistogramsLibrary.cxx:1151:7: error: uninitialized record type: 'PtBinEdges' [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
PWGDQ/Core/HistogramsLibrary.cxx:1160:7: error: uninitialized record type: 'CentBinEdges' [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
PWGDQ/Core/HistogramsLibrary.cxx:1207:134: error: use nullptr [modernize-use-nullptr,-warnings-as-errors]
PWGDQ/Core/HistogramsLibrary.cxx:1208:134: error: use nullptr [modernize-use-nullptr,-warnings-as-errors]
PWGDQ/Core/HistogramsLibrary.cxx:1254:5: error: uninitialized record type: 'coschiBins' [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
PWGDQ/Core/HistogramsLibrary.cxx:1268:124: error: use nullptr [modernize-use-nullptr,-warnings-as-errors]
PWGDQ/Core/HistogramsLibrary.cxx:1269:124: error: use nullptr [modernize-use-nullptr,-warnings-as-errors]
PWGDQ/Core/HistogramsLibrary.cxx:1270:124: error: use nullptr [modernize-use-nullptr,-warnings-as-errors]
PWGDQ/Core/HistogramsLibrary.cxx:1319:7: error: uninitialized record type: 'massBins' [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
PWGDQ/Core/HistogramsLibrary.cxx:1323:7: error: uninitialized record type: 'ptBins' [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
PWGDQ/Core/HistogramsLibrary.cxx:1354:9: error: uninitialized record type: 'massBins' [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
PWGDQ/Core/HistogramsLibrary.cxx:1365:146: error: use nullptr [modernize-use-nullptr,-warnings-as-errors]
PWGDQ/Core/HistogramsLibrary.cxx:1373:146: error: use nullptr [modernize-use-nullptr,-warnings-as-errors]
PWGDQ/Core/HistogramsLibrary.cxx:1419:9: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGDQ/Core/HistogramsLibrary.cxx:1423:146: error: use nullptr [modernize-use-nullptr,-warnings-as-errors]
PWGDQ/Core/HistogramsLibrary.cxx:1424:176: error: use nullptr [modernize-use-nullptr,-warnings-as-errors]
PWGDQ/Core/HistogramsLibrary.cxx:1429:147: error: use nullptr [modernize-use-nullptr,-warnings-as-errors]
PWGDQ/Core/HistogramsLibrary.cxx:1430:177: error: use nullptr [modernize-use-nullptr,-warnings-as-errors]
PWGDQ/Core/HistogramsLibrary.cxx:1435:147: error: use nullptr [modernize-use-nullptr,-warnings-as-errors]
PWGDQ/Core/HistogramsLibrary.cxx:1436:177: error: use nullptr [modernize-use-nullptr,-warnings-as-errors]
PWGDQ/Core/HistogramsLibrary.cxx:1475:134: error: use nullptr [modernize-use-nullptr,-warnings-as-errors]
PWGDQ/Core/HistogramsLibrary.cxx:1484:138: error: use nullptr [modernize-use-nullptr,-warnings-as-errors]
PWGDQ/Core/HistogramsLibrary.cxx:1493:134: error: use nullptr [modernize-use-nullptr,-warnings-as-errors]
PWGDQ/Core/HistogramsLibrary.cxx:1554:9: error: uninitialized record type: 'TauBinLims' [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
PWGDQ/Core/HistogramsLibrary.cxx:1588:132: error: use nullptr [modernize-use-nullptr,-warnings-as-errors]
[0 more errors; see full log]

Full log here.

remove unused code

7d77a63

ypwangg requested review from XiaozhiBai, alibuild, iarsene, mcoquet642 and mguilbau as code owners July 15, 2026 01:44

github-actions Bot added the pwgdq label Jul 15, 2026

github-actions Bot changed the title ~~remove unused code~~ [PWGDQ] remove unused code Jul 15, 2026

test hadronic v2

d39e480

fix some bugs in A2 event mixing

a96133d

alibuild mentioned this pull request Jul 15, 2026

Please consider the following formatting changes to #17068 ypwangg/O2Physics#11

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[PWGDQ] remove unused code#17068

[PWGDQ] remove unused code#17068
ypwangg wants to merge 3 commits into
AliceO2Group:masterfrom
ypwangg:A2-PR

ypwangg commented Jul 15, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Jul 15, 2026 •

edited

Loading

Uh oh!

alibuild commented Jul 15, 2026

Uh oh!

alibuild commented Jul 15, 2026

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

ypwangg commented Jul 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jul 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

alibuild commented Jul 15, 2026

Uh oh!

alibuild commented Jul 15, 2026

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

2 participants

ypwangg commented Jul 15, 2026 •

edited

Loading

github-actions Bot commented Jul 15, 2026 •

edited

Loading