Skip to content

[PWGJE] pvalue check on rho(phi) #17106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
joachimckh wants to merge 5 commits into
base: master
Choose a base branch
from
+13 −2
Open

[PWGJE] pvalue check on rho(phi) #17106

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
59a7f49
pvalue check on rho(phi)
joachimckh Jul 17, 2026
a9da120
linter
joachimckh Jul 17, 2026
e5c4d56
fix cpp issues
joachimckh Jul 17, 2026
da0a2b8
linter
joachimckh Jul 17, 2026
05ebb3e
clang/linter
joachimckh Jul 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 13 additions & 2 deletions PWGJE/Tasks/jetSpectraEseTask.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,6 +111,7 @@
Configurable<std::vector<float>> cfgOccupancyPtCut{"cfgOccupancyPtCut", {0, 100}, "pT cut"};

Configurable<bool> cfgrhoPhi{"cfgrhoPhi", true, "Flag for rho(phi)"};
Configurable<bool> cfgRhoPhiPvalCriteria{"cfgRhoPhiPvalCriteria", true, "Use <rho> instead of rho(phi) when the rho(phi) fit p-value is below 0.01"};

Configurable<int> cfgnTotalSystem{"cfgnTotalSystem", 7, "total qvector number // look in Qvector table for this number"};
Configurable<int> cfgnCorrLevel{"cfgnCorrLevel", 3, "QVector step: 0 = no corr, 1 = rect, 2 = twist, 3 = full"};
Expand Down Expand Up @@ -345,6 +346,7 @@

registry.add("eventQA/before/hVtxZ", ";z_{vtx} (cm);entries", {HistType::kTH1F, {{vertexZAxis}}});
registry.add("eventQA/after/hVtxZ", ";z_{vtx} (cm);entries", {HistType::kTH1F, {{vertexZAxis}}});
registry.add("eventQA/hRhoPhiCheck", "event status;event status;entries", {HistType::kTH1F, {{2, 0.0, 2.0}}});

registry.get<TH1>(HIST("eventQA/hEventCounter"))->GetXaxis()->SetBinLabel(kFilteredInputEv, "Input filtered event");
registry.get<TH1>(HIST("eventQA/hEventCounter"))->GetXaxis()->SetBinLabel(kEventSel, "Event selection");
Expand Down Expand Up @@ -605,7 +607,7 @@
if (cfg.hEff == nullptr) {
LOGF(fatal, "Could not find %s as TH1F in track efficiency list %s", efficiencyName.c_str(), cfgEfficiency.value.c_str());
}
LOGF(info, "Loaded tracking efficiency %s from %s (%p)", efficiencyName.c_str(), cfgEfficiency.value.c_str(), (void*)cfg.hEff);
LOGF(info, "Loaded tracking efficiency %s from %s (%p)", efficiencyName.c_str(), cfgEfficiency.value.c_str(), static_cast<void*>(cfg.hEff));
}
if (!cfgEfficiency3D.value.empty()) {
cfg.h3EffList = ccdb->getForTimeStamp<TList>(cfgEfficiency3D, timestamp);
Expand All @@ -616,7 +618,7 @@
if (cfg.h3Eff == nullptr) {
LOGF(fatal, "Could not find %s as TH3F in 3D track efficiency list %s", efficiencyName.c_str(), cfgEfficiency3D.value.c_str());
}
LOGF(info, "Loaded 3D tracking efficiency %s from %s (%p)", efficiencyName.c_str(), cfgEfficiency3D.value.c_str(), (void*)cfg.h3Eff);
LOGF(info, "Loaded 3D tracking efficiency %s from %s (%p)", efficiencyName.c_str(), cfgEfficiency3D.value.c_str(), static_cast<void*>(cfg.h3Eff));
cfg.is3D = true;
}
cfg.isLoaded = true;
Expand Down Expand Up @@ -1478,6 +1480,15 @@
return nullptr;

auto cDF = 1. - TMath::Gamma(nDF, chi2);
if constexpr (fillHist)
registry.fill(HIST("eventQA/hRhoPhiCheck"), 0.5);
if (cfgRhoPhiPvalCriteria && cDF < 0.01) {
const float noFlow = 0.0f;
modulationFit->SetParameter(1, noFlow); // o2-linter: disable=magic-number (fit params)

Check failure on line 1487 in PWGJE/Tasks/jetSpectraEseTask.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[magic-number] 

Avoid magic numbers in expressions. Assign the value to a clearly named variable or constant.
modulationFit->SetParameter(3, noFlow); // o2-linter: disable=magic-number (fit params)
if constexpr (fillHist)
registry.fill(HIST("eventQA/hRhoPhiCheck"), 1.5);
}

if constexpr (fillHist) {
registry.fill(HIST("eventQA/hPValueCentCDF"), col.centFT0M(), cDF);
Expand Down
Loading