Addressed the legacy Avatar situation with Transform#882
Merged
MikhailDeriabin merged 3 commits intoJul 25, 2026
Merged
Conversation
CapoMK25
requested review from
Iir0R,
MikhailDeriabin,
hoan301298,
psykkis and
tickBit
as code owners
July 22, 2026 14:04
tickBit
approved these changes
Jul 24, 2026
tickBit
left a comment
Collaborator
There was a problem hiding this comment.
Good and consistent solution. Approved.
Collaborator
|
I'll wait @CapoMK25 to update the branch, since it might cause merge conflicts or something unexpected. |
…-is-in-the-old-format
Codecov Report✅ All modified and coverable lines are covered by tests. 🚀 New features to boost your workflow:
|
MikhailDeriabin
enabled auto-merge
July 25, 2026 09:40
MikhailDeriabin
deleted the
799-bug-avatardata-in-the-friend-request-data-is-in-the-old-format
branch
July 25, 2026 09:43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brief description
#799
Addresses that issue with the absolute bare minimum amount of changes from the baseline setup. I incorporated the use of @Transform here to address the legacy AvatarData meshing with the new one.
Each unit test passes miraculously by default as well.
Change list
Transformfrom the class-transformer libraryBackend testing was done using a different approach, here's the output:
Another run right after to see that this sticks: