Eleino/refactor/615 refactor gallery unified schema for multiple images animation and optional links - #666
Conversation
…old photo object types and hooks
Rutjake
left a comment
There was a problem hiding this comment.
Great work overall! Just a small nitpick on type safety, left a comment inline below.
Skoivumaki
left a comment
There was a problem hiding this comment.
Massive issue, very good work. Directus schema is as issue required. There was no mention of i18n/translations for the object in the issue, but its nice to see you thought of it and implemented it + the social links should suffice👍
Thanks for cleaning up the unused files. I trust you actually checked that they weren't referenced in anything.
One small thing:
- Categories text disappears and component enters "desktop variant" after 770px when mobile is still relevant. Personally I think the desktop variant of tabs/categories should only render when they all fit on one row (unlike in example):
Obviously Figma example didnt take that many category tabs into account, but I think we'll manage.
So to clarify:
KeepTabNavigationin mobile variant (one with categories text) until all tabs fit on 1 row.
Thanks, I've updated tabs now, and yes, I checked that none of them were in use, there were some being used by the Comics page so I left those alone. |
📄 Pull Request Overview
Closes #615
🔧 Changes Made
Created PhotoObjectV2 on Directus, based on the data needed for displaying Gallery items.
Implemented code for fetching the new PhotoObjectV2 data from Directus and mapping it to useful format for displaying the data on the Gallery page.
✅ Checklist Before Submission
console.log()or other debugging statements are left.📝 Additional Information
Provide any additional context or information that reviewers may need to know:
Scrollbar example:
