Casimir43/enhancement/660 update prg page to match newest figma design - #668
Casimir43/enhancement/660 update prg page to match newest figma design#668Casimir43 wants to merge 11 commits into
Conversation
…e to registry details
Skoivumaki
left a comment
There was a problem hiding this comment.
Small UI fixes:
-
Text overflows when in split-view. (good rule is, if website looks bad on larger tablets, split-view is going to break):

-
Your mobile implementation of
CustomSwitchis clean, but in terms of user experience, its often bad to use icons to represent complex words. Simply fix it by disablingCustomSwitchfor mobile and loop the tabs as seen in Figma example 1 (mobile). Just remember to make it look good and not overflow:
Otherwise everything looks good 👍
eleino
left a comment
There was a problem hiding this comment.
Looks good, aside from the scaling issue on smaller screens, which is partly due to the Figma design using larger font sizes than usually. You could consider adding an intermediate breakpoint with a smaller font size so the page looks good on smaller screens as well.
| onOpen: () => setActiveTab(tab), | ||
| children: isMobileSize ? ( | ||
| /* eslint-disable-next-line @next/next/no-img-element */ | ||
| <img |
There was a problem hiding this comment.
One other thing: Why are you using <img> tag here instead of the Nextjs <Image> tag? In general we should avoid using code that requires disabling eslint checks if there are working alternatives.
📄 Pull Request Overview
Closes #660
🔧 Changes Made
Added a tab switcher to flip between Action Plan, Annual Report, and Association Rules. Also cleaned up the board member section and applied new design features.
✅ Checklist Before Submission
console.log()or other debugging statements are left. ✅📝 Additional Information