fix: exclude Deploy-SvcHealth-BuiltIn from base archetype to avoid AMBA Service Health duplication (#4210) - #2179
Open
pratyushverma63 wants to merge 1 commit into
Conversation
…BA duplication (#4210)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Fixes #4210
Deploy-SvcHealth-BuiltIn(assigned by the ALZrootarchetype) and AMBA'sDeploy-AMBA-Res-SvcHlthinitiative memberALZ_SHA_BuiltInboth reference the same built-in Service Health policy definition (98903777-a9f6-47f5-90a9-acaf62ab01a8). When both ALZ and AMBA are deployed to the same management-group hierarchy, each independently runs its own DINE remediation, producing duplicate action groups and duplicate Service Health alert rules (inrg-serviceHealthAlertandrg-amba-monitoring-001).The Enterprise-Scale ARM/portal path already avoids this via the mutually-exclusive
enableServiceHealthcondition. However, the ALZ Library (Terraform) path loses that protection becauseplatform/alzandplatform/ambaare generated from independent sources, so both assignments land together.Change
Set
enableServiceHealthBuiltInto"No"ineslzArm/eslzArm.terraform-sync.param.json. This excludesDeploy-SvcHealth-BuiltInfrom the generated ALZrootarchetype in the Azure Landing Zones Library, so the built-in Service Health assignment no longer conflicts with AMBA's initiative."enableServiceHealthBuiltIn": { - "value": "Yes" + "value": "No"Validation
Invoke-LibraryUpdatePolicyAssignmentArchetypes.ps1against this change — confirmedDeploy-SvcHealth-BuiltInis removed from the generatedroot.alz_archetype_definition.json.Post fix validation





This removes the built-in Service Health assignment from the base archetype for all Library consumers, including non-AMBA deployments, which would lose the default Service Health alerting unless they re-enable it.