SWI-11363 Send a User-Agent header on outbound Bandwidth requests#22
Open
kshahbw wants to merge 2 commits into
Open
SWI-11363 Send a User-Agent header on outbound Bandwidth requests#22kshahbw wants to merge 2 commits into
kshahbw wants to merge 2 commits into
Conversation
Add USER_AGENT (bw-voice-adapter/<version>, read from package.json at import time) and set it on every outbound Bandwidth call — the OAuth2 token exchange in token.ts and all six Voice API calls in client.ts. Lets Bandwidth attribute outbound traffic to this client and version.
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
kshahbw
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a
User-Agentheader to every outbound Bandwidth request so BW can attribute traffic to this client and version.What changed
src/bw/user-agent.ts— exportsUSER_AGENT = \/`, read frompackage.json` at import time (stays in sync with the package version automatically).src/bw/token.ts— setsUser-Agenton the OAuth2 token exchange.src/bw/client.ts— sets it on all six Voice API calls (createCall, modifyCall, getCall, listRecordings, getRecording, getRecordingMedia, updateRecording).Verification
npm run typecheckcleanUSER_AGENTresolves tobw-voice-adapter/0.1.0(becomesmigration-toolkit/0.1.0once the rebrand lands, since it readspackage.json).Independent of the Migration Toolkit rebrand PR — touches only
src/bw/.