test: add unit tests for newsletter buttons and verify target blank #138#174
Open
ahmad1368 wants to merge 1 commit into
Open
test: add unit tests for newsletter buttons and verify target blank #138#174ahmad1368 wants to merge 1 commit into
ahmad1368 wants to merge 1 commit into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
vincent6767
reviewed
Jul 12, 2026
| expect(newsletterContent.ctaHref).toBe("https://tally.so/r/mR6RBl"); | ||
| }); | ||
|
|
||
| // ۲. تست وجود هاردکد target="_blank" درون کامپوننت کاملا به صورت خودکار |
Contributor
There was a problem hiding this comment.
Hi @ahmad1368, can you use English for all comments in the PR? Thank you!
vincent6767
approved these changes
Jul 12, 2026
vincent6767
left a comment
vincent6767
left a comment
Contributor
There was a problem hiding this comment.
I approve the overall changes. @ahmad1368 Please address my comments before you merge. Thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #138
Changes made:
target="_blank"andrel="noopener noreferrer"insideNewsletter.astrocomponent.Newsletter333insrc/lib/content.ts.src/components/SubscribetoNewsletterButtom.test.tsto verify the exact data structure and ensure the component source file guarantees the secure target attributes.PTAL @vincent6767