Skip to content

Add navbar icons #5 #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
geobza wants to merge 2 commits into
base: main
Choose a base branch
from
+20 −5
Open

Add navbar icons #5 #31

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9d899da
Add navbar icons #5
geobza Jul 18, 2026
f8ef3d2
fix format check error
geobza Jul 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@
"@dagrejs/dagre": "^3.0.0",
"@xyflow/react": "^12.10.2",
"lucide-react": "^1.22.0",
"nvm": "^0.0.4",

@AJaccP AJaccP Jul 26, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a stray package got added unrelated to the ticket change, I'm guessing from a pnpm add nvm or something. The change doesn't need this so please run pnpm remove nvm on this branch and commit the updated package.json and pnpm-lock.yaml

Assuming it works as expected there should be no diff for these 2 files against main, so only the Header.tsx file would have changes in the PR.

"react": "^19.2.6",
"react-dom": "^19.2.6",
"react-router-dom": "^7.15.1",
Expand Down
10 changes: 10 additions & 0 deletions pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

14 changes: 9 additions & 5 deletions src/components/Header.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,22 +1,26 @@
import { NavLink } from 'react-router-dom';
import { Network } from 'lucide-react';

@AJaccP AJaccP Jul 26, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpick but since both are from the same module, this can be one import line:
import { Network, CalendarDays } from 'lucide-react';

Also the comment on line 5 can be removed since its just duplicating what the import already says

import { CalendarDays } from 'lucide-react';

// Import Network, CalendarDays

export default function Header() {
const linkClass = ({ isActive }: { isActive: boolean }) =>
isActive
? 'text-sm font-medium text-red-600'
: 'text-sm text-gray-600 hover:text-gray-900';
? 'flex items-center gap-1.5 text-sm font-medium text-red-600'
: 'flex items-center gap-1.5 text-sm text-gray-600 hover:text-gray-900';

return (
<header className="flex h-14 flex-none items-center gap-6 border-b border-gray-200 bg-white px-6">
<span className="font-semibold text-gray-900">
Carleton CS Course Graph
</span>
<nav className="flex gap-4">
<nav className="flex items-center gap-6">
<NavLink to="/explorer" className={linkClass}>
Explorer
<Network size={20} /> Explorer

@AJaccP AJaccP Jul 26, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the size of the icons, I think 16 looks better than 20 + it's consistent with the other lucide usage in the site's legend component. Can you please update size to 16 on both

</NavLink>
<NavLink to="/planner" className={linkClass}>
Planner
<CalendarDays size={20} /> Planner
</NavLink>
</nav>
</header>
Expand Down
Loading