chore(test): refresh cmip7_aft integration fixture #41
Merged
Conversation
✅ Deploy Preview for climate-ref canceled.
|
|
Important Review skippedToo many files! This PR contains 86 files, which is 36 over the limit of 50. To get a review, narrow the scope: Upgrade to a paid plan to raise the limit. ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (403)
📒 Files selected for processing (207)
You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
|
lewisjared
force-pushed
the
chore/refresh-integration-fixture
branch
from
July 16, 2026 14:30
5a3926e to
b65dcb7
Compare
lewisjared
force-pushed
the
chore/refresh-integration-fixture
branch
from
July 16, 2026 14:35
b65dcb7 to
8d8ce72
Compare
Replaces the fixture with a fresh full-provider solve run locally, on top of the 0.16.2 pin from #40. The DB is migrated to 0.16.2 head (a4c5d6e7f8b9) and loads UP_TO_DATE. - pmp now has 5 successful executions (was 0) - esmvaltool 16 successful; ilamb 1 (gpp-fluxnet2015) — most ILAMB diagnostics need reference datasets absent from the decimated sample-data after the obs4MIPs/obs4REF rework - pruned for git (~17M, was ~26M): dropped the two heavy regional-historical esmvaltool diagnostics (DB rows + results) and all .nc outputs; VACUUMed Constraint: fixture must stay small enough to commit to git Not-tested: ref-app backend suite locally (relies on PR CI against 0.16.2)
lewisjared
force-pushed
the
chore/refresh-integration-fixture
branch
from
July 16, 2026 14:41
8d8ce72 to
7d82662
Compare
kind is a CV dimension but climate_ref surfaces it as a dedicated field on each value and excludes it from the per-item dimensions mapping. Emitting it as a facet let callers filter on a key that never appears in item dimensions, which broke test_diagnostic_values_pagination_with_filter once a diagnostic whose top facet is kind became the first scalar diagnostic in the fixture. Confidence: high Scope-risk: narrow
lewisjared
changed the title
lewisjared
marked this pull request as ready for review
July 16, 2026 15:13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refresh the
test_cmip7_aftintegration fixture (+ one API fix)Fixture refresh
Replaces the backend integration fixture (
backend/tests/test-data/tests.integration.test_cmip7_aft/test_solve_cmip7_aft/) with a freshtest_solve_cmip7_aftsolve run locally with the full esmvaltool/pmp conda envs (ILAMB in-venv), migrated to 0.16.2's alembic head (a4c5d6e7f8b9, loadsUP_TO_DATE) and pruned for git.gpp-fluxnet2015): structural — the ILAMB provider was reworked onto obs4MIPs/obs4REF and the decimated sample-data lacks most ILAMB reference datasets, so those diagnostics no longer form execution groups.Size ~17M (was ~26M): dropped the two heavy
regional-historical-timeseries/-annual-cyclediagnostics (DB rows + results, ~159M of PNGs plus a 13MBseries.json) and all.ncoutputs (with theirexecution_outputrows).PRAGMA foreign_key_checkclean; every output row resolves to a file on disk; VACUUMed.exclude
kindfrom metric-value facetsThe refreshed data surfaced a latent inconsistency:
kindis a CV dimension but climate_ref surfaces it as a dedicated field on each value and excludes it from the per-itemdimensionsmapping. The values endpoint still emittedkindas a facet, so callers could filter on a key that never appears in item dimensions — breakingtest_diagnostic_values_pagination_with_filteronce akind-topped diagnostic became the first scalar diagnostic. Fixed by excludingkind(via a sharedNON_FACET_DIMENSIONSconstant) from the reader-built facets.