Skip to content

fix: render global analysis relations in PR diagrams#56

Merged
ivanmilevtues merged 1 commit into
mainfrom
fix/project-global-relations
Jul 15, 2026
Merged

fix: render global analysis relations in PR diagrams#56
ivanmilevtues merged 1 commit into
mainfrom
fix/project-global-relations

Conversation

@ivanmilevtues

Copy link
Copy Markdown
Member

Summary

  • load review analyses through Core's canonical unified-analysis parser
  • project global leaf relations onto every Mermaid render level using Core's relation projection logic
  • keep component-file dropdown status aligned with the projected Mermaid diff
  • add regression coverage for Core loader wiring, nested projection, and rendered global edges

This fixes the disconnected diagram observed in CodeBoarding/CodeBoarding-walkthrough#3. Replaying that PR's analysis artifact renders four top-level relations instead of one.

Test plan

  • python3 -m unittest discover -s tests (178 tests)
  • Black formatting check on touched Python files
  • git diff --check
  • Replayed the CodeBoarding-walkthrough PR Add --max-label flag to diff_to_mermaid #3 artifact against its base analysis

@codeboarding-review

codeboarding-review Bot commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

Architecture review · 1 component changed

graph LR
    n_Analysis_Orchestrator["Analysis Orchestrator"]
    n_Visual_Diffing_Rendering_Engine["Visual Diffing #38; Rendering Engine"]
    n_Documentation_CTA_Generator["Documentation #38; CTA Generator"]
    n_Telemetry_Feedback_Provider["Telemetry #38; Feedback Provider"]
    n_Analysis_Orchestrator -- "Orchestrates rendering lifecycle" --> n_Visual_Diffing_Rendering_Engine
    n_Analysis_Orchestrator -- "Triggers documentation build" --> n_Documentation_CTA_Generator
    n_Analysis_Orchestrator -- "Provides execution metrics" --> n_Telemetry_Feedback_Provider
    n_Visual_Diffing_Rendering_Engine -- "Provides diffing logic #38; status" --> n_Documentation_CTA_Generator
    n_Documentation_CTA_Generator -- "Resolves method-to-file mapping" --> n_Visual_Diffing_Rendering_Engine
    classDef added fill:#1f883d,stroke:#0b5d23,color:#ffffff;
    classDef modified fill:#bf8700,stroke:#7d4e00,color:#ffffff;
    classDef deleted fill:#cf222e,stroke:#82071e,color:#ffffff,stroke-dasharray:5 3;
    class n_Visual_Diffing_Rendering_Engine modified;
    linkStyle 0,1,2,3,4 stroke:#7d4e00,stroke-width:2px;
Loading

Colors indicate component changes compared to target branch main: 🟩 Added · 🟨 Modified · 🟥 Removed

Download the PR analysis artifacts from this workflow artifact.

Visual Diffing & Rendering Engine : 2 files changed
  • scripts/build_component_files.py
  • scripts/diff_to_mermaid.py

⚠️ 1 architecture issue found — open CodeBoarding to explore them.

Explore this PR’s architecture in your browser or VS Code.

codeboarding-action · run 29429738579

@Svilen-Stefanov Svilen-Stefanov left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to be working, let's merge it.

@ivanmilevtues ivanmilevtues merged commit 0a8328b into main Jul 15, 2026
3 checks passed
@ivanmilevtues ivanmilevtues deleted the fix/project-global-relations branch July 15, 2026 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants