Skip to content

Remove openssl11, OpenSSL 1.0 itself was supported until 2015#250

Merged
jwillemsen merged 1 commit into
DOCGroup:masterfrom
jwillemsen:jwi-depopenssl11
Jul 22, 2026
Merged

Remove openssl11, OpenSSL 1.0 itself was supported until 2015#250
jwillemsen merged 1 commit into
DOCGroup:masterfrom
jwillemsen:jwi-depopenssl11

Conversation

@jwillemsen

@jwillemsen jwillemsen commented Jul 20, 2026

Copy link
Copy Markdown
Member
* .github/workflows/windows.yml:
* config/global.features:
* config/openssl.mpb:
* docs/html/MakeProjectCreator.html:

Summary by CodeRabbit

  • Bug Fixes

    • Updated Windows builds to use the current OpenSSL libraries.
    • Enabled IPv6, Xerces3, and SSL features in Windows project generation.
    • Removed the obsolete OpenSSL 1.1 feature flag.
  • Documentation

    • Updated the documented global feature list to remove the obsolete OpenSSL 1.1 entry.

    * .github/workflows/windows.yml:
    * config/global.features:
    * config/openssl.mpb:
    * docs/html/MakeProjectCreator.html:
@coderabbitai

coderabbitai Bot commented Jul 20, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: cde69406-c1e1-489c-a852-9958bd46c1b1

📥 Commits

Reviewing files that changed from the base of the PR and between 1b5d735 and cf09b1e.

📒 Files selected for processing (4)
  • .github/workflows/windows.yml
  • config/global.features
  • config/openssl.mpb
  • docs/html/MakeProjectCreator.html
💤 Files with no reviewable changes (3)
  • .github/workflows/windows.yml
  • config/global.features
  • docs/html/MakeProjectCreator.html

Walkthrough

The OpenSSL 1.1 feature is removed from configuration and documentation. Windows OpenSSL linkage now uses libssl and libcrypto, while Windows CI enables IPv6, Xerces3, and SSL features.

Changes

OpenSSL feature alignment

Layer / File(s) Summary
OpenSSL configuration updates
config/global.features, config/openssl.mpb
Removes the openssl11 default and feature block, and changes Windows OpenSSL libraries to libssl and libcrypto.
CI and documentation synchronization
.github/workflows/windows.yml, docs/html/MakeProjectCreator.html
Windows feature generation adds ipv6, xerces3, and ssl; documentation removes the openssl11 entry.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Poem

A rabbit hops through flags so bright,
SSL and IPv6 take flight.
OpenSSL11 fades away,
New library names lead the way.
The docs now match the build tonight!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title matches the main change: removing openssl11 references from config, workflow, and docs.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@mergify

mergify Bot commented Jul 20, 2026

Copy link
Copy Markdown

Tick the box to add this pull request to the merge queue (same as @mergifyio queue).

  • Queue this pull request

@jwillemsen
jwillemsen merged commit c0cd382 into DOCGroup:master Jul 22, 2026
12 checks passed
@jwillemsen
jwillemsen deleted the jwi-depopenssl11 branch July 22, 2026 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant