Add TpkExtensions for Steam link creation and introduce unit tests - #53
Open
ecenshu wants to merge 1 commit into
Open
Add TpkExtensions for Steam link creation and introduce unit tests#53ecenshu wants to merge 1 commit into
ecenshu wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extracted SteamLink creation into helper function that is UnitTestable
Added UnitTest project and Tests for extracted functionality
SteamLinks now go through a few transformations from most exact to least.
Use steam_app_id for direct lookup
Use human_name if available and strip DLC/Steam suffixes as a search link
Use machine_name stripped of _steam/_choice as a search link
Otherwise return null and should bail out at the Link Creation caller