fix: resolve dashboard error trend indicators and add regression test…#157
Merged
georgidhristov merged 2 commits intoJul 19, 2026
Merged
Conversation
…s for full eviction
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the bug in our dashboard's error trend indicators where they were constantly stuck or overcorrecting to a neutral (→) state, especially when older metrics data was evicted from the store.
Now, the trend arrows dynamically and accurately reflect whether things are getting worse (↑ red) or improving (↓ green), even when partial or full data eviction happens. I've verified the UI manually, and it works flawlessly now!
-> File-by-File Changes
HtmlRenderer.cs
Updated the core window-boundary evaluation and trend calculation logic. Fixed the bug where the renderer failed to compute the correct direction once the historical comparison base shifted or got evicting from memory.
debugprobe.css & index.html
Adjusted the asset styling and HTML rendering bindings to support proper visual updates for the dynamic arrow indicators (↑, ↓, →).
DebugProbeOptions.cs & DebugProbeOptionsValidator.cs
Updated options structures and validation parameters to seamlessly support the trend window configuration changes without breaking any existing middleware configuration.
HtmlRendererTrendTests.cs (New Test File)
Added a complete set of regression unit tests covering the exact scenario that broke earlier (full-eviction causing a fallback to neutral). This ensures the trend arrows won't silently regress in future builds.
-> Verification & Testing Done
Manual Verification: Tested both the error spike scenario (50% ERRORS, ↑) and the recovery baseline (20% ERRORS, ↓). Both render correctly now.
Automated Tests: Ran dotnet test, and all the test suites (including the new regression unit tests) are passing perfectly with zero errors.
