Add point diagnostics, bullet proof completeness diagnostics - #62
Closed
bear-is-asleep wants to merge 3 commits into
Closed
Add point diagnostics, bullet proof completeness diagnostics#62bear-is-asleep wants to merge 3 commits into
bear-is-asleep wants to merge 3 commits into
Conversation
bear-is-asleep
marked this pull request as ready for review
February 28, 2025 17:23
Member
|
Thank you for this contribution. We selectively incorporated both substantive commits from this PR onto current main while preserving Bear's authorship (b6dd9dc and 6b94238), then modernized and tested the implementation in 0ac98b96 and 89a91444. The resulting PointCompletenessAna is truth-only, keeps point_metrics as a configuration alias, supports documented ns time filtering and configurable distance matching, handles empty point collections explicitly, and includes the track-completeness robustness guards from the proposal. Since the contribution is now incorporated and corrected on main, I am closing this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.