Fix infinite loop when setting record's own value from on_update callback#202
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #202 +/- ##
==========================================
+ Coverage 88.16% 88.39% +0.22%
==========================================
Files 15 15
Lines 1259 1258 -1
==========================================
+ Hits 1110 1112 +2
+ Misses 149 146 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
AlexanderWells-diamond
force-pushed
the
reimplement_db_put_field
branch
from
February 3, 2026 16:15
9c7b738 to
8b7ad74
Compare
AlexanderWells-diamond
changed the title
AlexanderWells-diamond
force-pushed
the
reimplement_db_put_field
branch
from
February 3, 2026 16:18
8b7ad74 to
6efe75d
Compare
This works around issues with potential infinite loops, even if process=False, as seen in issue #201.
AlexanderWells-diamond
force-pushed
the
reimplement_db_put_field
branch
from
February 4, 2026 12:42
89dc86a to
061483b
Compare
Araneidae
approved these changes
Feb 4, 2026
Araneidae
left a comment
Araneidae
left a comment
Collaborator
There was a problem hiding this comment.
I do have two minor layout changes I'd prefer to see for the sake of consistency, but this seems good to me.
AlexanderWells-diamond
added a commit
that referenced
this pull request
Jul 16, 2026
This was an oversight in PR #202
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This works around issues with potential infinite loops, even if process=False, as seen in issue #201.
Closes #201