Skip to content

Add remaining builtin themes - #38

Open
Bludwarf wants to merge 12 commits into
Edditoria:masterfrom
Bludwarf:master
Open

Add remaining builtin themes#38
Bludwarf wants to merge 12 commits into
Edditoria:masterfrom
Bludwarf:master

Conversation

@Bludwarf

Copy link
Copy Markdown

No description provided.

@Edditoria
Edditoria self-requested a review January 30, 2019 12:41
@Edditoria

Edditoria commented Jan 30, 2019

Copy link
Copy Markdown
Owner

Thanks for these nice works.

I'm reviewing them one-by-one. Will do some research on the concept of design from original creators. If process is smooth, I will do some adjustments, and push more commits to the branch Bludwarf-master.

If you already have some resources/documentations, feel free to tell me. Many thanks!

It will take some days. Please stay tune. :)

@pixelskyales

Copy link
Copy Markdown

hello everyone !
I thank you so much for all, I just watched and got the lesson.
Do you want to start the project now? Thank you very much.
hola

@pixelskyales

Copy link
Copy Markdown

access

@Bludwarf

Bludwarf commented Feb 18, 2019

Copy link
Copy Markdown
Author

@Edditoria, @pixelskyales I have tried to match built-in xml themes with json and I made a small node program to automate it. Check it out here : https://github.com/Bludwarf/markdown-plus-plus-generator.

This is a draft as I originaly created this program inside this repository. You may find for instance the path "../build/data.template.json" that points to the build directory of this repository. I will try to enhance it if it may be useful for someone.

I have found the builtin themes from this repository : https://github.com/jsleroy/notepad-plus/tree/master/PowerEditor/installer/themes

@olokos olokos left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will actually make markdown-plus-plus complete.
@Edditoria
Could you merge this, for the better of everybody?
I already tried it and looks awesome!

@Edditoria

Copy link
Copy Markdown
Owner

This is a smart work that automate things. And it works.

But the colors are wired as a "article-editing" tool. And they doesn't align with the idea/principle of the original designer (if any). Btw, the existing style config in NPP doesn't follow the originals, too.

In the meantime, please use @Bludwarf 's work.

@olokos What theme(s) do you use in NPP?

@olokos

olokos commented Apr 22, 2020

Copy link
Copy Markdown

@Edditotria

I'm using obsidian theme, it's the only one that looks right" to me, but sadly it's missing from your repo. 😢

I would highly appreciate if you could implement at least obsidian, it blends really well with my system wide black mode everywhere, including websites.

@Edditoria

Edditoria commented Apr 27, 2020

Copy link
Copy Markdown
Owner

@olokos Obsidian has been created as you wish.

Run npx markdown-plus-plus obsidian if you have node installed.

Thanks for request! 😄

@olokos

olokos commented Apr 28, 2020

Copy link
Copy Markdown

Thank you so much @Edditoria !
I have also noticed one small bug, sorry for cluttering this PR with it, but it's worth mentioning.
Cool SS
The text should be italic but instead color is cut off and only the first letter is properly formatted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants