Expand Storybook coverage and cleanup storybook install - #391
Open
dcgoodwin2112 wants to merge 4 commits into
Open
Expand Storybook coverage and cleanup storybook install#391dcgoodwin2112 wants to merge 4 commits into
dcgoodwin2112 wants to merge 4 commits into
Conversation
dcgoodwin2112
marked this pull request as draft
May 26, 2026 14:54
dcgoodwin2112
force-pushed
the
expand-storybook-coverage
branch
from
June 8, 2026 15:27
1e798d8 to
970a4bb
Compare
… documentation - Updated imports in multiple components to use type definitions from '@storybook/react-vite'. - Enhanced story documentation for various components including HeaderTagline, Hero, LargeFileDialog, and others. - Added new stories for components like ManageColumns, MobileHeader, SearchModal, and ResourcePreview. - Improved existing stories by adding parameters and decorators for better context and layout. - Removed unused mock data and streamlined story args for clarity. - Added global type declarations for image modules to support asset imports.
… several components
dcgoodwin2112
force-pushed
the
expand-storybook-coverage
branch
from
June 30, 2026 14:47
970a4bb to
8db2c06
Compare
- Added new CMS-related packages: @cmsgov/ds-cms-gov, @cmsgov/ds-healthcare-gov, and @cmsgov/ds-medicare-gov. - Extended global type definitions to include CSS modules and inline CSS. - Updated TypeScript configuration to include all TypeScript and declaration files in the .storybook directory.
dcgoodwin2112
marked this pull request as ready for review
June 30, 2026 15:36
brdunfield
reviewed
Jul 1, 2026
| import NavBar from '../NavBar/Navbar'; | ||
| import cmsLogo from '../../assets/images/CMSGovLogo-O.png'; | ||
| import cmsLogoWhite from '../../assets/images/CMSgov@2x-white-O.png'; | ||
| import './mobile-header.scss'; |
Contributor
There was a problem hiding this comment.
is this deletion intended?
Contributor
Author
There was a problem hiding this comment.
this one was intentional 👍 It looks like the actual scss file was deleted a while ago, so this has just been a dangling import.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expand storybook coverage to cover more components. Add theme switcher to switch between different design system themes.
Testing
npm inpm run storybook