Skip to content

#4621 Intentionally set revision timestamp. - #4755

Draft
swirtSJW wants to merge 1 commit into
4.xfrom
4621-add-revision-time-in-save
Draft

#4621 Intentionally set revision timestamp.#4755
swirtSJW wants to merge 1 commit into
4.xfrom
4621-add-revision-time-in-save

Conversation

@swirtSJW

@swirtSJW swirtSJW commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

Fixes #4621

This is a draft because it is completely untested yet

Describe your changes

QA Steps

  • Add manual QA steps in checklist format for a reviewer to perform. Be as specific as possible, provide examples if appropriate.

Checklist before requesting review

If any of these are left unchecked, please provide an explanation

  • I have updated or added tests to cover my code
  • I have updated or added documentation

@swirtSJW swirtSJW mentioned this pull request Jul 9, 2026
7 tasks
@swirtSJW

swirtSJW commented Jul 9, 2026

Copy link
Copy Markdown
Contributor Author

the tests are failing with

  1. Drupal\Tests\dkan_metastore\Unit\Storage\DataTest::testPublishDraftDataset
    Error: Call to a member function getDefinition() on null

I'll have to step through to see how/if this is related to the new code.

@swirtSJW
swirtSJW force-pushed the 4621-add-revision-time-in-save branch 3 times, most recently from 0f95744 to 64f5b4e Compare July 9, 2026 14:47
@swirtSJW
swirtSJW force-pushed the 4621-add-revision-time-in-save branch from 64f5b4e to 5ea071b Compare July 9, 2026 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Publishing a metastore does not change revision date

1 participant