Skip to content

feat(ops/gmpctl): create pull request automatically for vulnfix command#2012

Open
bwplotka wants to merge 3 commits into
mainfrom
gmpctl-pr
Open

feat(ops/gmpctl): create pull request automatically for vulnfix command#2012
bwplotka wants to merge 3 commits into
mainfrom
gmpctl-pr

Conversation

@bwplotka

Copy link
Copy Markdown
Collaborator

Port creation of pull request for vulnfix command from PR #1971 to main branch.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request automates the creation of pull requests in gmpctl after executing vulnerability fixes. It introduces a new github.go file that uses the GitHub CLI (gh) to check for existing open pull requests and create new ones if none exist. Additionally, it updates branch mapping to associate the "main" branch with the PrometheusEngine project. The review feedback suggests setting HideOutputs: true when calling gh pr create to avoid contaminating the captured PR URL with stderr messages, and removing a redundant strings.TrimSpace call.

Comment thread ops/gmpctl/github.go
Comment thread ops/gmpctl/github.go Outdated
Comment thread ops/gmpctl/gmp.go Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant