Fix HMR breaking after vite server restarts - #1732
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: 1506beb The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When vite restarts the dev server (config change, lockfile change, pressing
r), HMR would break until the dev server was manually restarted, failing on every save with:Vite creates the replacement server before closing the old one, and two things went wrong in that window:
Compiler ownership: the dev compiler lived in a module-level
export let compilerinvite/hmr.ts. By the time the old server's close handler ran, that binding pointed at the replacement's compiler, so the old server shut down the new server's compiler and database connection.Session overlap: the new session wiped and recreated the orchestration database while the old session's plugin processes were still running. Plugin registration collided with leftover rows (
UNIQUE constraint failed: plugins.name), and since the Go side treated that as fatal, the fresh plugin died and the orchestrator was left dialing a port nobody listens on (ECONNREFUSED).