Add selection-aware custom menu items#11
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
gtokman
marked this pull request as ready for review
July 12, 2026 16:46
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
isAvailablepredicate toLTXCustomMenuItemMarkdownTextView.selectionChangeHandlerWhy
Consumers need mutually exclusive selection commands such as Highlight and Unhighlight. Previously the menu was rendered before the selection-change delegate callback, so the visible action lagged behind the current dragged range.
Validation
swift buildswift test --filter SelectionMenuTests(2 tests passed)swift testruns 134 tests; the two existing grammar-trait-dependent tests fail because the default package traits do not enable Python or Swift grammars