Skip to content

Updated README.md on Python requirements - #98

Open
shaikhq wants to merge 3 commits into
IBM:masterfrom
shaikhq:patch-2
Open

Updated README.md on Python requirements#98
shaikhq wants to merge 3 commits into
IBM:masterfrom
shaikhq:patch-2

Conversation

@shaikhq

@shaikhq shaikhq commented Mar 15, 2025

Copy link
Copy Markdown
Collaborator

No description provided.

@shaikhq
shaikhq requested a review from kdrodger as a code owner March 15, 2025 18:51

@kdrodger kdrodger left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just needs your sign-off on the commit (DCO) before it can be merged.

shaikhq added 2 commits March 15, 2025 13:03
Signed-off-by: shaikhq <shaikhq@ca.ibm.com>
Signed-off-by: shaikhq <shaikhq@ca.ibm.com>
@shaikhq

shaikhq commented Mar 15, 2025

Copy link
Copy Markdown
Collaborator Author

LGTM. Just needs your sign-off on the commit (DCO) before it can be merged.

Thanks. I just pushed a new commit with sign-off:
ad5f3e3

Now sure why the DCO message is still showing up in the PR, hasn't picked up sign-off from the latest commit.

@kdrodger

Copy link
Copy Markdown
Contributor

Interesting. I'm not certain why. Maybe because one of the commits is not signed, or possibly because you don't have your name in the DCO sign-off - you put your userid instead, although I've seen that work before successfully.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants