Skip to content

fix: revert regex changes to address a regression issue#840

Merged
pyrooka merged 3 commits into
mainfrom
nb/fix-regex-regression
Jul 24, 2026
Merged

fix: revert regex changes to address a regression issue#840
pyrooka merged 3 commits into
mainfrom
nb/fix-regex-regression

Conversation

@pyrooka

@pyrooka pyrooka commented Jul 24, 2026

Copy link
Copy Markdown
Member

PR summary

This reverts commit 30d9a51.

PR Checklist

General checklist

Please make sure that your PR fulfills the following requirements:

  • The commit message follows the Angular Commit Message Guidelines.
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • Dependencies have been updated as needed
  • .secrets.baseline has been updated as needed
  • npm run update-utilities has been run if any files in packages/utilities/src have been updated

Checklist for adding a new validation rule:

  • Added new validation rule definition (packages/ruleset/src/rules/*.js, index.js)
  • If necessary, added new validation rule implementation (packages/ruleset/src/functions/*.js, updated index.js)
  • Added new rule to default configuration (packages/ruleset/src/ibm-oas.js)
  • Added tests for new rule (packages/ruleset/test/*.test.js)
  • Added docs for new rule (docs/ibm-cloud-rules.md)
  • Added scoring rubric entry for new rule (packages/validator/src/scoring-tool/rubric.js)

@pyrooka
pyrooka requested review from Andris28 and diatrcz July 24, 2026 14:33

@diatrcz diatrcz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@pyrooka
pyrooka merged commit 58e6daf into main Jul 24, 2026
9 checks passed
@pyrooka
pyrooka deleted the nb/fix-regex-regression branch July 24, 2026 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants