Fix(Accessibility): Add aria-expanded to presentation table controls#10490
Fix(Accessibility): Add aria-expanded to presentation table controls#10490ZallaxDev wants to merge 2 commits into
Conversation
… Ticket 43793 Adds the missing aria-expanded attribute to presentation table expand/collapse glyphs to fix a WCAG violation for screen readers. This involves extending the Glyph component (PHP/Template) to support the attribute, setting the correct initial state in the Table/Renderer, and updating the attribute dynamically in presentationtable.class.js when the row state changes.
Annett7811
left a comment
There was a problem hiding this comment.
From an accessibility perspective, this looks good to me. Thank you very much for your work.
|
Hello @ZallaxDev. |
oliversamoila
left a comment
There was a problem hiding this comment.
Hello together,
from an UX and UI perspective, the result looks good. Thank you very much for your contribution, @ZallaxDev
I'm forwarding this to @thibsy for code review. He may contact you with change requests or incorporate the changes directly (That includes cherry picking too.)
Kind regards,
@oliversamoila (as UI coordinator)
25a2000 to
a04d2bf
Compare
|
Hi @thibsy, Hope everything is going well!! Please let us know if you encounter any issues or if any further changes are required. Best, |
Adds the missing aria-expanded attribute to presentation table expand/collapse glyphs to fix a WCAG violation for screen readers.
This involves extending the Glyph component (PHP/Template) to support the attribute, setting the correct initial state in the Table/Renderer, and updating the attribute dynamically in
presentationtable.class.jswhen the row state changes.To optimise time, we want to be sure that the implementation is correct, since if any additional changes are required, the tests will have to be updated again, with the corresponding time expenditure on this task.
Therefore, we would appreciate feedback on these changes, and when we can confirm that they are adequate, we will update the tests in this same PR before performing the merge.
Ticket 43793