Skip to content

Fix(Accessibility): Add aria-expanded to presentation table controls#10490

Open
ZallaxDev wants to merge 2 commits into
ILIAS-eLearning:release_10from
surlabs:ilias10_a11y_M43793
Open

Fix(Accessibility): Add aria-expanded to presentation table controls#10490
ZallaxDev wants to merge 2 commits into
ILIAS-eLearning:release_10from
surlabs:ilias10_a11y_M43793

Conversation

@ZallaxDev

Copy link
Copy Markdown
Contributor

Adds the missing aria-expanded attribute to presentation table expand/collapse glyphs to fix a WCAG violation for screen readers.

This involves extending the Glyph component (PHP/Template) to support the attribute, setting the correct initial state in the Table/Renderer, and updating the attribute dynamically in presentationtable.class.js when the row state changes.

⚠️ This change currently does not pass the PHP Unit Tests, because they modify the HTML generated in these tests.
To optimise time, we want to be sure that the implementation is correct, since if any additional changes are required, the tests will have to be updated again, with the corresponding time expenditure on this task.
Therefore, we would appreciate feedback on these changes, and when we can confirm that they are adequate, we will update the tests in this same PR before performing the merge.

Ticket 43793

… Ticket 43793

Adds the missing aria-expanded attribute to presentation table expand/collapse glyphs to fix a WCAG violation for screen readers.

This involves extending the Glyph component (PHP/Template) to support the attribute, setting the correct initial state in the Table/Renderer, and updating the attribute dynamically in presentationtable.class.js when the row state changes.
@ZallaxDev ZallaxDev added bugfix kitchen sink php Pull requests that update Php code javascript Pull requests that update Javascript code labels Nov 19, 2025

@Annett7811 Annett7811 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From an accessibility perspective, this looks good to me. Thank you very much for your work.

@oliversamoila

Copy link
Copy Markdown
Contributor

Hello @ZallaxDev.
Thank you very much for your contribution and your PR. Please also provide PRs for releases 9, 11 and the trunk.
Please have a look to the failed checks.
Many thanks for your support.
Best regards,
@oliversamoila

@BettyFromHH BettyFromHH added the css/html Pull requests that propose changes to CSS/SCSS or HTML files. label Jan 21, 2026
@Annett7811 Annett7811 added the accessibility Pull requests that propose A11Y changes. label Feb 6, 2026

@oliversamoila oliversamoila left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello together,
from an UX and UI perspective, the result looks good. Thank you very much for your contribution, @ZallaxDev
I'm forwarding this to @thibsy for code review. He may contact you with change requests or incorporate the changes directly (That includes cherry picking too.)

Kind regards,
@oliversamoila (as UI coordinator)

@abrahammordev

Copy link
Copy Markdown
Contributor

Hi @thibsy,

Hope everything is going well!!
We have updated the test implementation to reflect the improvements made.

Please let us know if you encounter any issues or if any further changes are required.

Best,
Abraham

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

accessibility Pull requests that propose A11Y changes. bugfix css/html Pull requests that propose changes to CSS/SCSS or HTML files. javascript Pull requests that update Javascript code kitchen sink php Pull requests that update Php code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants