ILIASObject: consistently use long description on object creation so that multilingualism does not get confused (48105)#11810
Open
schmitz-ilias wants to merge 1 commit into
Conversation
…that multilingualism does not get confused (48105)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes 48105, where on creation of containers only the short description is written to
object_translation. The entry inobject_translationsupersedes the long description persisted inobject_description, so only the short description is shown everywhere.The cause of this is that the initial translations of a container are set in
ilContainer::create, from the description as it's currently set in the to-be-created object viailObject::getLongDescription. The description set in the to-be-created object is however only the short version, seeilObjectGUI::saveObject.