Genome metadata QC filtering#31
Open
epbrenner wants to merge 5 commits into
Open
Conversation
Added ability to filter BV-BRC genomes based on genome stat metadata, including CheckM completeness and CheckM contamination as defaults. Also enabled optional checking of genome length, CDS count, and GC content based on deviations from median distribution per bug. Updated genome downloader functions to use ftpes_download_one instead of old ftp_download_one, and moved a dot function helper to inside the ftpes_download_one loop to avoid issues with BiocParallel workers not understanding what that helper is.
Uncommenting a helper that was still needed for several calls. Fixing stuff I broke myself!
Updating to remove BiocParallel implementation that caused bugs. Patching back to prior Future implementation instead. CLI version of genome downloading appears to have issues that may be separate and requires further troubleshooting.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding new functionality.
@amcim Most importantly for you, I know you've been working on the BiocParallel stuff and had since moved on to another implementation (futures?). I just want to confirm that this script is working for me locally after my patches, but this is just based off main. If we're changing implementations, some of my updates aren't necessary.
For testers:
Open GitHub Desktop or your preferred method of fetching a PR, fetch this PR, source data_curation.R into your favorite CLI, and try
retrieveMetadata(user_bacs = "Shigella flexneri")for a quick bug, orprepareGenomes(user_bacs = "Shigella flexneri")to also test the genome downloader. I have tried this out locally for Enterobacter spp., K. pnumoniae, and Campylobacter jejuni. Give it a spin!