Add lyrics tab - #104

Open

LucasRBA wants to merge 14 commits into

Jamie098:masterfrom

LucasRBA:feature/lyrics

LucasRBA commented May 7, 2026

Summary

Add Lyrics tab for compatible Navidrome/Subsonic servers.
Support synced .lrc, unsynced .txt, and embedded lyrics.
Add Lyrics UI, input, docs, and tests.

Verification

cargo test

LucasRBA added 4 commits

May 7, 2026 01:24


          feat: complete synchronized lyrics with F8 shortcut, auto-scroll and …

196f15b

…Navidrome support


          Updates the documentation and fix mouse functionality on lyrics tab

226a0e7


          test: add comprehensive lyrics retrieval tests for modern and legacy …

e0dca97

…endpoints


          Removes dead/unused code

7a9a6d5

LucasRBA requested a review from Jamie098 as a code owner

May 7, 2026 08:05

Jamie098 requested changes

View reviewed changes

Jamie098 left a comment

Owner

Not had time to do a full review, once these have been addressed I will re-review. Thanks

docs/keybindings.md Outdated

src/app/state.rs Outdated

src/app/state.rs Outdated

src/app/input_lyrics.rs

src/subsonic/models.rs Outdated

src/ui/pages/lyrics.rs

src/app/playback.rs Outdated

LucasRBA added 2 commits

May 8, 2026 04:08


          Adress the issues in the first code review of the feature/lyrics PR

1ac4265


          Fix an issue triggered when clicking the song caused the lyrics to no…

2ef7275

…t be retrieved properly

LucasRBA commented

View reviewed changes

docs/keybindings.md

LucasRBA commented

View reviewed changes

docs/keybindings.md

LucasRBA commented

View reviewed changes

src/app/input.rs Outdated

LucasRBA commented

View reviewed changes

src/app/playback.rs

LucasRBA commented

View reviewed changes

src/app/state.rs

LucasRBA commented

View reviewed changes

src/app/state.rs

LucasRBA commented

View reviewed changes

src/ui/footer.rs

LucasRBA added 2 commits

May 29, 2026 16:36


          Reviews necessary serde default usage

c56855d


          Removes unused fields

6d303c9

LucasRBA commented

View reviewed changes

src/subsonic/models.rs

LucasRBA commented

View reviewed changes

src/subsonic/models.rs

LucasRBA added 3 commits

May 29, 2026 20:42


          Fix conflicts

9e6d1de


          Fix unused code and Fn KeyCode issue

aea1361


          Fix Lyrics page title

979ff09

LucasRBA requested a review from Jamie098

May 30, 2026 04:09

LucasRBA added 3 commits

June 7, 2026 19:51


          Fix state init conflict: volume + lyrics_state

c3a3414


          Merge master into feature/lyrics

12589fd


          Changes keybindings and documentation related to lyrics functionality

1ccb5ea

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet