fix(studio): color picker popover overlays the renderer#82
Merged
Conversation
The upstream popover's position:absolute kept it clipped inside the inspector's scroll container at the panel's left edge. Escape without measuring anything: position:fixed with top:auto keeps the box at its static position (level with its trigger row, CSS 2.1 §10.6.4) while escaping every overflow ancestor; right: 308px (panel width constant + gap, commented) lands it just left of the panel, over the renderer; z-index 1000 tops the canvas and hit-map overlay. Ancestor chain verified free of transform/filter containing blocks. Panel scroll closes the picker (a fixed popover would detach from its row). Documented residual: a row very near the window bottom can still overflow below the viewport — upstream collision handling remains the real fix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User feedback on #81 (screenshot): the popover was clipped at the inspector panel's left edge — the upstream
position:absolutekeeps it inside the panel's scroll container, so it couldn't overlay the canvas.Measurement-free escape (one themed CSS block + one handler; upstream primitive untouched):
position: fixed; top: auto— the box keeps its static position (level with its trigger row, spec behavior, the classic escape-the-scroll-container dropdown pattern) while escaping every overflow ancestorright: 308px— panel width constant (300,view.rs) + gap, commented for future changes: the popover always lands just left of the panel, over the renderer;z-index: 1000tops the canvas and hit-map overlay (ancestor chain verified free oftransform/filtercontaining blocks)Documented residual: a row very near the window bottom can still push the 340px popover below the viewport — that's upstream collision handling's job (verified absent at HEAD in #81); escalate/contribute if hit in practice.
Verify:
cargo check -p rustmotion-studio✓ ·cargo test --workspace→ 403 passed ✓ ·cargo fmt --check✓ · clippy gated ≤1 ✓