fix(camera): resolve RCE acquisition path against data root for manifest - #28
Draft
larsrollik wants to merge 1 commit into
Draft
fix(camera): resolve RCE acquisition path against data root for manifest#28larsrollik wants to merge 1 commit into
larsrollik wants to merge 1 commit into
Conversation
The RCE adapter received acquisition_path relative to the data root (the remote conductor needs it relative), but reused it to write the local session_manifest.yaml. That write resolved against the process CWD and raised FileNotFoundError on machines whose CWD is not the data root, so RCE camera setups logged a traceback and never recorded the camera peer. - resolve acquisition_path against output_dir before registering and finalizing the camera peer, leaving the relative path to the conductor - add regression test covering the relative-path caller usage Tests: +1 (4 passing in test_camera_peer_registration). Version bump: patch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
On acquisition machines using the RCE camera backend, every session logged a
FileNotFoundErrortraceback and silently failed to record the camera acquisition insession_manifest.yaml.The RCE adapter receives
acquisition_pathrelative to the data root (the remote conductor needs it relative), but reused that same relative value to write the localsession_manifest.yaml. The write resolved against the process CWD, which on most machines is not the data root, so the directory did not exist and the manifest write raisedFileNotFoundError. It was caught as best-effort bookkeeping (logged as a WARNING, acquisition continued), so it surfaced as noise plus a missing camera peer entry.Only RCE setups were affected: FLIR setups pass an absolute
acqdir, and no-camera setups skip registration entirely.Fix
acquisition_pathagainstoutput_dir(the data root) before registering and finalizing the camera peer, leaving the relative path untouched for the remote conductor.Tests
4 passingintest_camera_peer_registration.Version bump: patch.