Fixed a bug in get_latency_configuration when there are no volume level latency configurations#282
Open
kcantrel wants to merge 5 commits into
Open
Fixed a bug in get_latency_configuration when there are no volume level latency configurations#282kcantrel wants to merge 5 commits into
kcantrel wants to merge 5 commits into
Conversation
…el latency configurations. Also, renamed it 'list_eda_latency_config'. Also, renamed 'list_latency_events' to 'list_eda_latency_events'.
Contributor
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
There was a problem hiding this comment.
Pull request overview
This PR updates the Workload Factory API sample scripts to (1) avoid failures when an account has no volume-level latency configuration, and (2) standardize naming by moving latency-related scripts under an eda-prefixed naming scheme.
Changes:
- Add a guard in
list_eda_latency_configto handle accounts with no volume-level latency configurations. - Introduce
list_eda_latency_eventsto list latency events for a BlueXP account and update README links accordingly. - Extend
list_credentialswith a-joption and improve robustness of its jq parsing for nullable fields.
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| Management-Utilities/Workload-Factory-API-Samples/README.md | Updates the script catalog for renamed/added latency scripts. |
| Management-Utilities/Workload-Factory-API-Samples/list_eda_latency_events | New script to list EDA latency events for a BlueXP account. |
| Management-Utilities/Workload-Factory-API-Samples/list_eda_latency_config | Adds an early-exit guard when no per-volume configs exist. |
| Management-Utilities/Workload-Factory-API-Samples/list_credentials | Adds -j output option and adjusts jq formatting/field handling. |
Comments suppressed due to low confidence (1)
Management-Utilities/Workload-Factory-API-Samples/list_eda_latency_config:131
- The new empty-filesystems guard is fragile because the jq output is unquoted and compared as a string. If jq ever returns an empty value, the test can error (e.g., "[: ==: unary operator expected"). Quote the substitution and use a numeric compare.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also, renamed it 'list_eda_latency_config'.
Also, renamed 'list_latency_events' to 'list_eda_latency_events' to be more consistent with the other scripts.