fix(buttons): prime ADC channel before setting ladder pin attenuation - #125
Merged
jonasniesner merged 1 commit intoJul 26, 2026
Merged
Conversation
analogSetPinAttenuation() no-ops with an esp32-hal-adc 'Pin is not configured as analog channel' error unless the pin is already attached to the ADC, and attachment only happens on the first analogRead(). Do a throwaway read in registerAdcLadder() first so the ADC_11db attenuation call takes effect and the boot log stays clean. No behavior change in practice: the core's default attenuation is also 11 dB, so ladder readings are unchanged. Verified on an XTEINK X4 (ESP32-C3): error line gone from boot, both ladders register, and button presses on both ADC pins still classify to the same ids.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
analogSetPinAttenuation() no-ops with an esp32-hal-adc 'Pin is not configured as analog channel' error unless the pin is already attached to the ADC, and attachment only happens on the first analogRead(). Do a throwaway read in registerAdcLadder() first so the ADC_11db attenuation call takes effect and the boot log stays clean.
No behavior change in practice: the core's default attenuation is also 11 dB, so ladder readings are unchanged. Verified on an XTEINK X4 (ESP32-C3): error line gone from boot, both ladders register, and button presses on both ADC pins still classify to the same ids. This is purely so someone looking at the boot logs doesn't think there is an actual problem.