Skip to content

Add dedicated mobile and Settings navigation stacks#618

Draft
marksftw wants to merge 7 commits into
masterfrom
mobile-navigation
Draft

Add dedicated mobile and Settings navigation stacks#618
marksftw wants to merge 7 commits into
masterfrom
mobile-navigation

Conversation

@marksftw

@marksftw marksftw commented Jul 11, 2026

Copy link
Copy Markdown
Contributor

Summary

  • rebases the six-commit mobile-navigation series onto origin/master (e36e5d0)
  • replaces compact/mobile sidebar navigation with the shared full-screen MainMenu page while retaining the existing 296px desktop sidebar
  • adds versioned menu/project/chat/New Chat history with Back/Hamburger behavior, iOS Tauri edge swipe, compact Settings push/pop, and chat unmount/catch-up lifecycle
  • scales page-mode menu controls to phone proportions: 44px targets, 16px labels, 20px icons/wordmark, 60px overflow clearance, symmetric 16px insets, safe-area footer, and scrollable short-landscape behavior
  • keeps the desktop-only workspace mode switch out of page mode
  • hardens browser Forward/project draft scope, missing-chat fallback, slow conversation creation, duplicate attachment submissions, and Settings/transition cleanup
  • updates docs/mobile-navigation-plan.md with the implemented sizing and remaining device checks

Validation

  • bun test — 286 passing, 0 failing
  • bun run typecheck — passed
  • bun run lint — passed with 12 existing warnings and 0 errors
  • bun run build — passed
  • bun run format:check — passed
  • git diff --check — passed
  • focused mobile navigation/lifecycle suite — 59 passing, 0 failing
  • generated production CSS verified for 44px targets, 60px title clearance, viewport-limited dropdowns, and safe-area padding
  • pre-commit hook independently reran formatting, the production build, and all 286 tests successfully

Manual validation still required

Authenticated visual/device testing was unavailable: the managed workspace CLI is not installed, the local service ports were down, and the branch preview requires Cloudflare Access. These checks remain open:

  • authenticated 390×844, 430×932, 844×390, breakpoint-adjacent, and normal desktop layouts in light and dark modes
  • long-title, expanded-project, pinned/recent, search, selection, context-menu, Settings, and usage interactions on physical devices
  • physical iPhone edge swipe plus iOS/Android lifecycle, safe-area, and keyboard checks

@coderabbitai

coderabbitai Bot commented Jul 11, 2026

Copy link
Copy Markdown

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: eb61553e-9c94-488c-a233-b6e8425e45c9

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch mobile-navigation

Comment @coderabbitai help to get the list of available commands.

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Jul 11, 2026

Copy link
Copy Markdown

Deploying maple with  Cloudflare Pages  Cloudflare Pages

Latest commit: 41622d7
Status: ✅  Deploy successful!
Preview URL: https://39775c7f.maple-ca8.pages.dev
Branch Preview URL: https://mobile-navigation.maple-ca8.pages.dev

View logs

@marksftw marksftw changed the title Add dedicated mobile navigation stack Add dedicated mobile and Settings navigation stacks Jul 12, 2026
@marksftw
marksftw force-pushed the mobile-navigation branch from 6734f6a to c3f6aab Compare July 21, 2026 04:48
@marksftw
marksftw force-pushed the mobile-navigation branch from c3f6aab to 41622d7 Compare July 26, 2026 03:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant