feat: copy arm64 install script update - #2746
Conversation
|
@greptile review |
Greptile SummaryThis PR extends the install script's architecture check to allow
Confidence Score: 5/5Safe to merge — the change is a one-line guard expansion with a corrected error message and no other behavioural impact. The diff touches only the architecture guard in No files require special attention. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[install_shadowbox called] --> B["MACHINE_TYPE = uname -m"]
B --> C{Architecture check}
C -->|x86_64| D[Continue installation]
C -->|aarch64| D
C -->|arm64| D
C -->|Other| E["log_error: Unsupported machine type\nSupported: x86_64, aarch64/arm64"]
E --> F[exit 1]
D --> G[verify Docker installed & running]
G --> H[Create Outline directory]
H --> I[Configure ports, certs, hostname]
I --> J[start_shadowbox container]
J --> K[start_watchtower]
K --> L[Wait for health check]
L --> M[Installation complete]
Reviews (1): Last reviewed commit: "copy arm64 install script update" | Re-trigger Greptile |
d988e44 to
8af4692
Compare
This is a copy of @oceanapplications install script update from OutlineFoundation/outline-server#1700
This removes a check in the install script which disallowed arm64 machines. But per OutlineFoundation/outline-server#1700 CI and user testing arm64 does work.
This will require a server release to pick up the taskfile changes: https://github.com/OutlineFoundation/outline-server/pull/1700/changes#diff-f1d02bdf4c6eae0cd8305fa3c0081dc6899415740812e098c70b99abf0e7b465
DO NOT MERGE until after that release.