Skip to content

feat: copy arm64 install script update - #2746

Open
ohnorobo wants to merge 1 commit into
masterfrom
arm64-script-copy
Open

feat: copy arm64 install script update#2746
ohnorobo wants to merge 1 commit into
masterfrom
arm64-script-copy

Conversation

@ohnorobo

@ohnorobo ohnorobo commented Apr 13, 2026

Copy link
Copy Markdown
Contributor

This is a copy of @oceanapplications install script update from OutlineFoundation/outline-server#1700

This removes a check in the install script which disallowed arm64 machines. But per OutlineFoundation/outline-server#1700 CI and user testing arm64 does work.

This will require a server release to pick up the taskfile changes: https://github.com/OutlineFoundation/outline-server/pull/1700/changes#diff-f1d02bdf4c6eae0cd8305fa3c0081dc6899415740812e098c70b99abf0e7b465
DO NOT MERGE until after that release.

@ohnorobo ohnorobo changed the title copy arm64 install script update feat: copy arm64 install script update Apr 13, 2026
@ohnorobo
ohnorobo marked this pull request as ready for review April 13, 2026 20:32
@ohnorobo
ohnorobo requested a review from a team as a code owner April 13, 2026 20:32
@fortuna

fortuna commented May 7, 2026

Copy link
Copy Markdown
Collaborator

@greptile review

@greptile-apps

greptile-apps Bot commented May 7, 2026

Copy link
Copy Markdown

Greptile Summary

This PR extends the install script's architecture check to allow aarch64 and arm64 machines in addition to x86_64, enabling Outline Server installation on ARM64 hosts. The change mirrors the upstream server fix (outline-server#1700) which confirmed ARM64 compatibility via CI and user testing.

  • The architecture guard in install_shadowbox() now permits aarch64 (Linux ARM64 naming) and arm64 (macOS/BSD naming) alongside x86_64, and updates the error message to list all supported architectures.
  • No other logic is changed; the Docker image pull and container startup remain identical for all architectures.

Confidence Score: 5/5

Safe to merge — the change is a one-line guard expansion with a corrected error message and no other behavioural impact.

The diff touches only the architecture guard in install_shadowbox. Both aarch64 (Linux) and arm64 (macOS/BSD) are the same physical architecture reported by uname -m on different OS families, so including both is correct. The upstream server repo already validated ARM64 compatibility through CI and user testing. The rest of the install flow — Docker verification, directory setup, container start, Watchtower — is unchanged and architecture-agnostic at the shell level.

No files require special attention.

Important Files Changed

Filename Overview
server_manager/install_scripts/install_server.sh Architecture guard expanded to allow aarch64/arm64; error message updated accordingly. Change is minimal and correct.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[install_shadowbox called] --> B["MACHINE_TYPE = uname -m"]
    B --> C{Architecture check}
    C -->|x86_64| D[Continue installation]
    C -->|aarch64| D
    C -->|arm64| D
    C -->|Other| E["log_error: Unsupported machine type\nSupported: x86_64, aarch64/arm64"]
    E --> F[exit 1]
    D --> G[verify Docker installed & running]
    G --> H[Create Outline directory]
    H --> I[Configure ports, certs, hostname]
    I --> J[start_shadowbox container]
    J --> K[start_watchtower]
    K --> L[Wait for health check]
    L --> M[Installation complete]
Loading

Reviews (1): Last reviewed commit: "copy arm64 install script update" | Re-trigger Greptile

@ohnorobo
ohnorobo force-pushed the arm64-script-copy branch from d988e44 to 8af4692 Compare June 30, 2026 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants