use zero for land-values throughout Parcels#2762
Open
erikvansebille wants to merge 2 commits into
Open
Conversation
erikvansebille
commented
Jul 23, 2026
Comment on lines
+514
to
+515
| arr = field_data.isel(time=0) if "time" in field_data.dims else field_data | ||
| if xr.ufuncs.isnan(arr).any(): |
Member
Author
There was a problem hiding this comment.
Since isnan is not a lazy function, we need to be careful not to check the entire DataArray. Here only checking the first time step, under the assumption that if there is no land in that first time step it will also not be there in other time steps
Admittedly, this is a bit of a hacky fix, since we have to compute the entire first time slice of each Field
If you know of a cleaner way to do this, I'd be very open to that
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR implements the definition that land values are zero in Parcels. This choice is intuitive for velocities (since ocean velocities are zero on land) and is needed for slip boundary conditions. For tracer fields, using zero for land also works nicer because NaNs currently throw errors. The
XLinearInvdistLandTracerinterpolator also assumes that land is 0.0This PR adds a
_assert_no_nan_in_field_data()function that throws aValueErrorwhen there are NaNs in the Sgrid-dataset, and addsfillna(0)calls to some of the convert functions.This PR supersedes #2451
Checklist
mainfor normal development,v3-supportfor v3 support)AI Disclosure
None