Skip to content

Add support for pob.codes build exporting, and pob:// protocol for launching PoB from pob.codes#9939

Open
AdamZ-8113 wants to merge 1 commit into
PathOfBuildingCommunity:devfrom
AdamZ-8113:feature/pob-codes-build-sharing
Open

Add support for pob.codes build exporting, and pob:// protocol for launching PoB from pob.codes#9939
AdamZ-8113 wants to merge 1 commit into
PathOfBuildingCommunity:devfrom
AdamZ-8113:feature/pob-codes-build-sharing

Conversation

@AdamZ-8113

Copy link
Copy Markdown

No reported Issues Fixed

Description of the problem being solved:

This adds https://pob.codes/ as a supported site for exporting builds directly from PoB, and also will allow me to add an "Open in PoB" button to the site so that users can launch the build into PoB without copy/pasting build codes.

I've briefly talked with LocalIdentity about this on Discord (I'm hammerlock.) but I haven't heard back in a while. Transparently he hasn't explicitly agreed to approve this change, though he seemed open to it. My hope is that by submitting a PR it simplifies the process for you all. I'm happy to provide as much detail as is needed about pob.codes for this to be approved.

If you don't want pob.codes to be available for export, we could omit codeOut, PostUrl, and postFields, so that I could still add a 'launch with PoB' button to my website.

Steps taken to verify a working solution:

Link to a build that showcases this PR:

N/A

Before screenshot:

image

After screenshot:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant