Add support for pob.codes build exporting, and pob:// protocol for launching PoB from pob.codes#9939
Open
AdamZ-8113 wants to merge 1 commit into
Conversation
…unching PoB from pob.codes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No reported Issues Fixed
Description of the problem being solved:
This adds https://pob.codes/ as a supported site for exporting builds directly from PoB, and also will allow me to add an "Open in PoB" button to the site so that users can launch the build into PoB without copy/pasting build codes.
I've briefly talked with LocalIdentity about this on Discord (I'm
hammerlock.) but I haven't heard back in a while. Transparently he hasn't explicitly agreed to approve this change, though he seemed open to it. My hope is that by submitting a PR it simplifies the process for you all. I'm happy to provide as much detail as is needed about pob.codes for this to be approved.If you don't want pob.codes to be available for export, we could omit
codeOut,PostUrl, andpostFields, so that I could still add a 'launch with PoB' button to my website.Steps taken to verify a working solution:
Link to a build that showcases this PR:
N/A
Before screenshot:
After screenshot: