fix: transform svgPathSelected when using RTL and Zelos#10152
Merged
Conversation
mikeharv
changed the title
mikeharv
changed the title
gonfunko
approved these changes
Jul 17, 2026
gonfunko
left a comment
gonfunko
left a comment
Contributor
There was a problem hiding this comment.
This still works on the main workspace too right? I know I made some change to fix this bug there but must have missed this case.
Contributor
Author
Yes, I'm not seeing any regressions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Fixes #10151
Proposed Changes
Update
flipRTL()to also transformsvgPathSelectedwhen it exists. This is the same pattern Geras uses for its light/dark paths ingeras/path_object.ts.Reason for Changes
From the issue:
Test Coverage
Documentation
Additional Information