Inherit patcher types - #39
Open
Nytra wants to merge 2 commits into
Open
Conversation
Member
|
I'm cool with this change as long as it doesn't break existing or future pre-patchers. Meaning it would require some extensive testing. |
Author
|
I've tested it with Arti's FourLeafClover mod and it works, I'm not sure what else there is to test. |
|
as relevant context heres why my upstream pr was denied for now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes pre-patcher types be inherited which matches the behavior of plugin types.
Description
There is some difference between the way plugin types and patcher types are found in assemblies.
The plugin types will search with inheritance whereas the patcher types will not.
This PR makes the plugins and patchers use the same searching code essentially.
Current plugin searching code which this PR is based off:
BepisLoader/BepInEx.Core/Bootstrap/BaseChainloader.cs
Line 112 in 29e3aeb
BepisLoader/BepInEx.Core/Bootstrap/BaseChainloader.cs
Line 115 in 29e3aeb
Plugin attribute code which passes the third parameter to make it use inheritance:
BepisLoader/BepInEx.Core/Contract/Attributes.cs
Line 68 in 29e3aeb
Motivation and Context
I need this for my UniModFramework
How Has This Been Tested?
Tested by loading some pre-patchers and they seem to work.
Screenshots (if appropriate):
N/a
Types of changes
Checklist: