fix: correct sbom-create-commands []interface{} fallback and test compilation - #1245
Merged
Conversation
The ok variable from the []string type assertion was never updated after
the []interface{} conversion, causing custom commands provided as
[]interface{} to always fall back to default SBOM generation. Fix by
checking len(customSbomGenCmds) == 0 instead.
Also fix the GetModuleSBomGenCommands tests from PR #1212: replace
undefined getTestPath calls with dir.Loc{} zero values, and correct
assertions to match CmdConverter's actual output structure (path
prepended as commands[0][0]).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GetModuleSBomGenCommandsintroduced by Fix sbom-create-commands type assertion to handle []interface{} #1212: theokvariable from the[]stringtype assertion was never updated after the[]interface{}conversion loop, so custom SBOM commands provided as[]interface{}(the normal YAML unmarshal result) always fell back to default generation instead of using the provided commandsundefined: getTestPathininternal/commands/commands_test.go) also introduced by Fix sbom-create-commands type assertion to handle []interface{} #1212CmdConverter's actual output structure (working directory prepended ascommands[0][0])Root cause
Fixed by using
len(customSbomGenCmds) == 0which correctly handles all cases.Test plan
go build ./internal/commands/...compiles without errorsgo test ./internal/commands/...— all 36 tests pass