Skip to content

Type preview store client test double#8090

Draft
alfonso-noriega wants to merge 1 commit into
mainfrom
maintenance-preview-store-client-type
Draft

Type preview store client test double#8090
alfonso-noriega wants to merge 1 commit into
mainfrom
maintenance-preview-store-client-type

Conversation

@alfonso-noriega

@alfonso-noriega alfonso-noriega commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

WHY are these changes introduced?

A preview-store create service test used as any for a client options test double even though a narrow exported type is available.

WHAT is this pull request doing?

Imports PreviewStoreClientOptions as a type and uses it for the test client object instead of casting to any.

How to test your changes?

pnpm nx run cli-kit:build --skip-nx-cache
pnpm nx run organizations:build --skip-nx-cache
pnpm --dir packages/store vitest src/cli/services/store/create/preview/index.test.ts
pnpm --dir packages/store type-check
pnpm --dir packages/store lint

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes
  • I've considered analytics changes to measure impact
  • This change is not user-facing; no changeset is needed.

Assisted-By: devx/d9c9b8a1-2521-4fdd-af59-d77381c6f0ee

Copy link
Copy Markdown
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions Bot added the no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users. label Jul 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant